Skip to content

chore(serialization): Use msgpack-compact by default#11094

Merged
TomAFrench merged 5 commits intoaf/msgpack-defaultfrom
af/msgpack-compact-default
Jan 6, 2026
Merged

chore(serialization): Use msgpack-compact by default#11094
TomAFrench merged 5 commits intoaf/msgpack-defaultfrom
af/msgpack-compact-default

Conversation

@aakoshh
Copy link
Contributor

@aakoshh aakoshh commented Jan 6, 2026

Description

Problem

Resolves the desire from the Barretenberg team to make msgpack-compact the default format.

Summary

Changes the default circuit serialization format to msgpack-compact, which results in structs being serialized as arrays, without field names.

Additional Context

User Documentation

Check one:

  • No user documentation needed.
  • Changes in docs/ included in this PR.
  • [For Experimental Features] Changes in docs/ to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@aakoshh aakoshh changed the base branch from master to af/msgpack-default January 6, 2026 13:28
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: fcaf30f Previous: f51cad2 Ratio
rollup-block-root-single-tx 0.003 s 0.002 s 1.50

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@aakoshh aakoshh marked this pull request as ready for review January 6, 2026 13:42
@aakoshh aakoshh requested a review from TomAFrench January 6, 2026 13:42
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: cb24311 Previous: 99bb8b5 Ratio
test_report_zkpassport_noir-ecdsa_ 3 s 2 s 1.50

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@TomAFrench TomAFrench merged commit 023e77e into af/msgpack-default Jan 6, 2026
122 of 127 checks passed
@TomAFrench TomAFrench deleted the af/msgpack-compact-default branch January 6, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants