chore(frontend): Correct type for struct field on type mismatch and extra negative case unit tests #10493
Merged
chore(frontend): Correct type for struct field on type mismatch and extra negative case unit tests #10493
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 204660f | Previous: b34828f | Ratio |
|---|---|---|---|
rollup-block-root-single-tx |
0.003 s |
0.002 s |
1.50 |
rollup-checkpoint-merge |
0.004 s |
0.003 s |
1.33 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 3475024 | Previous: b34828f | Ratio |
|---|---|---|---|
test_report_zkpassport_noir-ecdsa_ |
3 s |
2 s |
1.50 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
asterite
approved these changes
Nov 13, 2025
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 14, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix(fuzzer): Set `in_dynamic` in `gen_match` (noir-lang/noir#10470) chore(elaborator): Check that assert message fragments are ABI compatible (noir-lang/noir#10491) feat(fuzz): Add support for more functions in comptime_vs_brillig_direct (noir-lang/noir#10500) chore(frontend): Correct type for struct field on type mismatch and extra negative case unit tests (noir-lang/noir#10493) chore: improve register moves in brillig return code-gen (noir-lang/noir#10305) END_COMMIT_OVERRIDE
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 14, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix(fuzzer): Set `in_dynamic` in `gen_match` (noir-lang/noir#10470) chore(elaborator): Check that assert message fragments are ABI compatible (noir-lang/noir#10491) feat(fuzz): Add support for more functions in comptime_vs_brillig_direct (noir-lang/noir#10500) chore(frontend): Correct type for struct field on type mismatch and extra negative case unit tests (noir-lang/noir#10493) chore: improve register moves in brillig return code-gen (noir-lang/noir#10305) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
Resolves #10492
Working towards audit of the elaborator group 7a
Summary
I added various negative case tests for struct patterns that match the tuple pattern tests.
I also fixed #10492 by simply using the actual type when resolving constructor pattern fields. The new
struct_pattern_with_mismatched_typetest has an error onlet _check: u32 = x;due to this change. On master, this test only has an error onlet Foo { x } = value;.As a result of switching from passing both the
actual_typeandexpected_typetoresolve_constructor_pattern_fieldsI was able to remove passingexpected_typeat all.I also added a
parenthesized_patterntest for full coverage as I substituted thePattern::Parenthesizedmatch case with a panic and no frontend tests failed.Additional Context
User Documentation
Check one:
PR Checklist
cargo fmton default settings.