Skip to content

fix: disallow keywords in attributes #10473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomAFrench merged 1 commit into from
Nov 11, 2025
Merged

fix: disallow keywords in attributes #10473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 1 addition & 25 deletions compiler/noirc_frontend/src/parser/parser/attributes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,15 +143,7 @@ impl Parser<'_> {
}

fn parse_non_tag_attribute(&mut self, start_location: Location) -> Attribute {
if matches!(&self.token.token(), Token::Keyword(..))
&& (self.next_is(Token::LeftParen) || self.next_is(Token::RightBracket))
{
// This is a Meta attribute with the syntax `keyword(arg1, arg2, .., argN)`
let path = Path::from_single(self.token.to_string(), self.current_token_location);
let name = MetaAttributeName::Path(path);
self.bump();
self.parse_meta_attribute(name, start_location)
} else if let Some(path) = self.parse_path_no_turbofish() {
if let Some(path) = self.parse_path_no_turbofish() {
if let Some(ident) = path.as_ident() {
if ident.as_str() == "test" {
// The test attribute is the only secondary attribute that has `a = b` in its syntax
Expand Down Expand Up @@ -764,22 +756,6 @@ mod tests {
assert!(meta.arguments.is_empty());
}

#[test]
fn parses_meta_attribute_single_identifier_as_keyword() {
let src = "#[dep]";
let mut parser = Parser::for_str_with_dummy_file(src);
let (attribute, _span) = parser.parse_attribute().unwrap();
expect_no_errors(&parser.errors);
let Attribute::Secondary(attribute) = attribute else {
panic!("Expected secondary attribute");
};
let SecondaryAttributeKind::Meta(meta) = attribute.kind else {
panic!("Expected meta attribute");
};
assert_eq!(meta.name.to_string(), "dep");
assert!(meta.arguments.is_empty());
}

#[test]
fn parses_meta_attribute_single_identifier_with_arguments() {
let src = "#[foo(1, 2, 3)]";
Expand Down
Loading