fix: avoid producing duplicate private error messages

compiler/noirc_frontend/src/elaborator/scope.rs

@@ -1,6 +1,7 @@
 //! Lexical scoping, variable lookup, and closure capture tracking.
 
 use crate::ast::{ERROR_IDENT, Ident};
+use crate::elaborator::path_resolution::PathResolution;
 use crate::hir::def_map::{LocalModuleId, ModuleId};
 
 use crate::hir::scope::{Scope as GenericScope, ScopeTree as GenericScopeTree};
@@ -226,8 +227,9 @@ impl Elaborator<'_> {
         path: TypedPath,
         mode: PathResolutionMode,
     ) -> Option<Shared<TypeAlias>> {
-        match self.resolve_path_or_error_inner(path, PathResolutionTarget::Type, mode) {
-            Ok(PathResolutionItem::TypeAlias(type_alias_id)) => {
+        match self.resolve_path_inner(path, PathResolutionTarget::Type, mode) {
+            Ok(PathResolution { item: PathResolutionItem::TypeAlias(type_alias_id), errors }) => {
+                self.push_errors(errors);
                 Some(self.interner.get_type_alias(type_alias_id))
             }
             _ => None,

compiler/noirc_frontend/src/elaborator/types.rs

@@ -13,7 +13,7 @@ use crate::{
         AsTraitPath, BinaryOpKind, GenericTypeArgs, Ident, PathKind, UnaryOp, UnresolvedType,
         UnresolvedTypeData, UnresolvedTypeExpression, WILDCARD_TYPE,
     },
-    elaborator::UnstableFeature,
+    elaborator::{UnstableFeature, path_resolution::PathResolution},
     hir::{
         def_collector::dc_crate::CompilationError,
         def_map::{ModuleDefId, fully_qualified_module_path},
@@ -619,8 +619,10 @@ impl Elaborator<'_> {
         }
 
         // If we cannot find a local generic of the same name, try to look up a global
-        match self.resolve_path_or_error_inner(path.clone(), PathResolutionTarget::Value, mode) {
-            Ok(PathResolutionItem::Global(id)) => {
+        match self.resolve_path_inner(path.clone(), PathResolutionTarget::Value, mode) {
+            Ok(PathResolution { item: PathResolutionItem::Global(id), errors }) => {
+                self.push_errors(errors);
+
                 if let Some(current_item) = self.current_item {
                     self.interner.add_global_dependency(current_item, id);
                 }