Skip to content

chore: use SignedField::from_signed in enums.rs #10408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vezenovm merged 1 commit into from
Nov 6, 2025
Merged

chore: use SignedField::from_signed in enums.rs #10408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 4 additions & 17 deletions compiler/noirc_frontend/src/elaborator/enums.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,26 +836,13 @@ impl Elaborator<'_> {
expr_location: location,
});

// Convert a signed integer type like i32 to SignedField
macro_rules! signed_to_signed_field {
($value:expr) => {{
let negative = $value < 0;
// Widen the value so that SignedType::MIN does not wrap to 0 when negated below
let mut widened = i128::from($value);
if negative {
widened = -widened;
}
SignedField::new(widened.into(), negative)
}};
}

let value = match constant {
Value::Bool(value) => SignedField::positive(value),
Value::Field(value) => value,
Value::I8(value) => signed_to_signed_field!(value),
Value::I16(value) => signed_to_signed_field!(value),
Value::I32(value) => signed_to_signed_field!(value),
Value::I64(value) => signed_to_signed_field!(value),
Value::I8(value) => SignedField::from_signed(value),
Value::I16(value) => SignedField::from_signed(value),
Value::I32(value) => SignedField::from_signed(value),
Value::I64(value) => SignedField::from_signed(value),
Value::U1(value) => SignedField::positive(value),
Value::U8(value) => SignedField::positive(u128::from(value)),
Value::U16(value) => SignedField::positive(u128::from(value)),
Expand Down
Loading