chore(brillig): Disable the decrement of the ref-count during array/vector copy#10386
Merged
jfecher merged 1 commit intoaf/audit-brillig-gen-5from Nov 10, 2025
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
ACVM Benchmarks
Details
| Benchmark suite | Current: 4574031 | Previous: 83245db | Ratio |
|---|---|---|---|
purely_sequential_opcodes |
265466 ns/iter (± 457) |
265534 ns/iter (± 1614) |
1.00 |
perfectly_parallel_opcodes |
235406 ns/iter (± 2420) |
236623 ns/iter (± 8229) |
0.99 |
perfectly_parallel_batch_inversion_opcodes |
2799104 ns/iter (± 1948) |
2800863 ns/iter (± 16743) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
Changes to number of Brillig opcodes executed
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
There was a problem hiding this comment.
Test Suite Duration
Details
| Benchmark suite | Current: 4574031 | Previous: 83245db | Ratio |
|---|---|---|---|
test_report_AztecProtocol_aztec-packages_noir-projects_aztec-nr |
124 s |
123 s |
1.01 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-contracts |
131 s |
137 s |
0.96 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob |
392 s |
414 s |
0.95 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_private-kernel-lib |
241 s |
244 s |
0.99 |
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_types |
141 s |
143 s |
0.99 |
test_report_noir-lang_noir-bignum_ |
154 s |
157 s |
0.98 |
test_report_noir-lang_noir_bigcurve_ |
330 s |
374 s |
0.88 |
test_report_noir-lang_sha256_ |
16 s |
15 s |
1.07 |
test_report_noir-lang_sha512_ |
14 s |
13 s |
1.08 |
test_report_zkpassport_noir-ecdsa_ |
1 s |
2 s |
0.50 |
test_report_zkpassport_noir_rsa_ |
1 s |
1 s |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Opcode count
Details
| Benchmark suite | Current: 4574031 | Previous: 83245db | Ratio |
|---|---|---|---|
private-kernel-inner |
18027 opcodes |
18027 opcodes |
1 |
private-kernel-reset |
80804 opcodes |
80804 opcodes |
1 |
private-kernel-tail |
17176 opcodes |
17176 opcodes |
1 |
rollup-block-root-first-empty-tx |
1100 opcodes |
1100 opcodes |
1 |
rollup-block-root-single-tx |
876 opcodes |
876 opcodes |
1 |
rollup-block-root |
2253 opcodes |
2253 opcodes |
1 |
rollup-checkpoint-merge |
2133 opcodes |
2133 opcodes |
1 |
rollup-checkpoint-root-single-block |
1919761 opcodes |
1919761 opcodes |
1 |
rollup-checkpoint-root |
1921135 opcodes |
1921135 opcodes |
1 |
rollup-root |
2608 opcodes |
2608 opcodes |
1 |
rollup-tx-base-private |
306830 opcodes |
306830 opcodes |
1 |
rollup-tx-base-public |
262441 opcodes |
262441 opcodes |
1 |
rollup-tx-merge |
1486 opcodes |
1486 opcodes |
1 |
semaphore-depth-10 |
5699 opcodes |
5699 opcodes |
1 |
sha512-100-bytes |
13173 opcodes |
13173 opcodes |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Compilation Time
Details
| Benchmark suite | Current: 4574031 | Previous: 83245db | Ratio |
|---|---|---|---|
private-kernel-inner |
2.008 s |
2.1 s |
0.96 |
private-kernel-reset |
8.138 s |
8.15 s |
1.00 |
private-kernel-tail |
1.558 s |
1.534 s |
1.02 |
rollup-block-root-first-empty-tx |
1.456 s |
1.398 s |
1.04 |
rollup-block-root-single-tx |
1.46 s |
1.38 s |
1.06 |
rollup-block-root |
1.49 s |
1.49 s |
1 |
rollup-checkpoint-merge |
1.442 s |
1.436 s |
1.00 |
rollup-checkpoint-root-single-block |
407 s |
412 s |
0.99 |
rollup-checkpoint-root |
403 s |
400 s |
1.01 |
rollup-root |
1.534 s |
1.532 s |
1.00 |
rollup-tx-base-private |
21.2 s |
21.3 s |
1.00 |
rollup-tx-base-public |
85.68 s |
83.1 s |
1.03 |
rollup-tx-merge |
1.426 s |
1.384 s |
1.03 |
semaphore-depth-10 |
0.824 s |
0.803 s |
1.03 |
sha512-100-bytes |
1.658 s |
1.605 s |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Execution Time
Details
| Benchmark suite | Current: 4574031 | Previous: 83245db | Ratio |
|---|---|---|---|
private-kernel-inner |
0.014 s |
0.014 s |
1 |
private-kernel-reset |
0.205 s |
0.206 s |
1.00 |
private-kernel-tail |
0.012 s |
0.012 s |
1 |
rollup-block-root-first-empty-tx |
0.003 s |
0.003 s |
1 |
rollup-block-root-single-tx |
0.002 s |
0.003 s |
0.67 |
rollup-block-root |
0.004 s |
0.004 s |
1 |
rollup-checkpoint-merge |
0.004 s |
0.003 s |
1.33 |
rollup-checkpoint-root-single-block |
23.8 s |
24 s |
0.99 |
rollup-checkpoint-root |
23.3 s |
23.1 s |
1.01 |
rollup-root |
0.004 s |
0.004 s |
1 |
rollup-tx-base-private |
0.341 s |
0.342 s |
1.00 |
rollup-tx-base-public |
0.258 s |
0.258 s |
1 |
rollup-tx-merge |
0.002 s |
0.002 s |
1 |
semaphore-depth-10 |
0.009 s |
0.009 s |
1 |
sha512-100-bytes |
0.054 s |
0.059 s |
0.92 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Artifact Size
Details
| Benchmark suite | Current: 4574031 | Previous: 83245db | Ratio |
|---|---|---|---|
private-kernel-inner |
770.2 KB |
770.2 KB |
1 |
private-kernel-reset |
2048.4 KB |
2048.4 KB |
1 |
private-kernel-tail |
627.3 KB |
627.3 KB |
1 |
rollup-block-root-first-empty-tx |
199.8 KB |
199.8 KB |
1 |
rollup-block-root-single-tx |
200.2 KB |
200.2 KB |
1 |
rollup-block-root |
280.4 KB |
280.4 KB |
1 |
rollup-checkpoint-merge |
363.1 KB |
363.1 KB |
1 |
rollup-checkpoint-root-single-block |
51638.8 KB |
51639.1 KB |
1.00 |
rollup-checkpoint-root |
51677.8 KB |
51678.4 KB |
1.00 |
rollup-root |
395.2 KB |
395.2 KB |
1 |
rollup-tx-base-private |
5620.7 KB |
5620.7 KB |
1 |
rollup-tx-base-public |
4878.6 KB |
4878.7 KB |
1.00 |
rollup-tx-merge |
178.9 KB |
178.9 KB |
1 |
semaphore-depth-10 |
570.9 KB |
570.9 KB |
1 |
sha512-100-bytes |
506.3 KB |
506.3 KB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 4574031 | Previous: 83245db | Ratio |
|---|---|---|---|
rollup-checkpoint-merge |
0.004 s |
0.003 s |
1.33 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Contributor
There was a problem hiding this comment.
Execution Memory
Details
| Benchmark suite | Current: 4574031 | Previous: 83245db | Ratio |
|---|---|---|---|
private-kernel-inner |
260.41 MB |
260.41 MB |
1 |
private-kernel-reset |
292.14 MB |
292.14 MB |
1 |
private-kernel-tail |
250.83 MB |
250.83 MB |
1 |
rollup-block-root |
339.1 MB |
339.1 MB |
1 |
rollup-checkpoint-merge |
337.86 MB |
337.86 MB |
1 |
rollup-checkpoint-root-single-block |
1760 MB |
1760 MB |
1 |
rollup-checkpoint-root |
1760 MB |
1760 MB |
1 |
rollup-root |
339.09 MB |
339.09 MB |
1 |
rollup-tx-base-private |
526.54 MB |
526.54 MB |
1 |
rollup-tx-base-public |
472.94 MB |
472.94 MB |
1 |
rollup-tx-merge |
337.32 MB |
337.32 MB |
1 |
semaphore_depth_10 |
73.69 MB |
73.69 MB |
1 |
sha512_100_bytes |
71.95 MB |
71.95 MB |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Compilation Memory
Details
| Benchmark suite | Current: 4574031 | Previous: 83245db | Ratio |
|---|---|---|---|
private-kernel-inner |
270.2 MB |
270.2 MB |
1 |
private-kernel-reset |
498.29 MB |
498.29 MB |
1 |
private-kernel-tail |
256.77 MB |
256.77 MB |
1 |
rollup-block-root-first-empty-tx |
339.76 MB |
339.76 MB |
1 |
rollup-block-root-single-tx |
338.21 MB |
338.21 MB |
1 |
rollup-block-root |
340.98 MB |
340.99 MB |
1.00 |
rollup-checkpoint-merge |
340.96 MB |
340.96 MB |
1 |
rollup-checkpoint-root-single-block |
11250 MB |
11250 MB |
1 |
rollup-checkpoint-root |
11260 MB |
11260 MB |
1 |
rollup-root |
342.5 MB |
342.5 MB |
1 |
rollup-tx-base-private |
1070 MB |
1070 MB |
1 |
rollup-tx-base-public |
3030 MB |
3030 MB |
1 |
rollup-tx-merge |
337.78 MB |
337.78 MB |
1 |
semaphore_depth_10 |
92.17 MB |
92.17 MB |
1 |
sha512_100_bytes |
185.46 MB |
185.47 MB |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
aakoshh
force-pushed
the
af/brillig-disable-dec-rc
branch
from
4412fed to
4574031
Compare
jfecher
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Follow up for the discussion in #10335 (comment)
Summary*
Disables the decrement of the ref-count which was fixed in #10335, but deemed not worth doing.
Additional Context
I left the methods in place so we still have a reference of where it was okay to decrement the RC, if we want to revisit this as noted in #10335 (comment)
It would be good to merge this after merging #10335 to highlight this decision on its own.
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.