feat: Merge all contracts into one ABI#1033
Conversation
|
Note: We may want to add a test to see what happens when two contracts in different modules are compiled with the same name (This was a concern that was present in the previous implementation) |
TomAFrench
left a comment
There was a problem hiding this comment.
There's similar changes which would have to be made to the wasm crate here in order to be consistent.
My preference on this is that we remove support for compiling contracts in TS for now as we're going to be making too many breaking changes. @kobyhallx
Ideally we have this for offsite, so they can compile and make tests in typescript. Its not a hard condition and if it makes the lives of tooling folks hard we can find an alternative. I'm guessing the painpoint you are referring to is when we are developing on master since, once we cut a release the ts and native should be synced up? |
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
In that case we need to update |
…/noir into kw/serialize-contracts
Related issue(s)
Resolves #
Description
This:
Summary of changes
Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Documentation needs
Additional context