Skip to content

chore(frontend): Comptime attribute source order unit tests#10322

Merged
vezenovm merged 1 commit intomv/comptime-item-gen-testsfrom
mv/comptime-source-order-unit-tests
Oct 30, 2025
Merged

chore(frontend): Comptime attribute source order unit tests#10322
vezenovm merged 1 commit intomv/comptime-item-gen-testsfrom
mv/comptime-source-order-unit-tests

Conversation

@vezenovm
Copy link
Contributor

Description

Problem*

Working towards green-light of the Elaborator

Summary*

I made a few tests that check the following attribute orderings:

  • 3 functions in textual order
  • 2 sibling modules
  • Parent-child
  • 2 levels of child module nesting

I noticed we had the attribute_order integration test once I had already started on these unit tests but I thought they would be good to keep either way. Unit tests almost act a complementary to documentation and allow for easier debugging if issues ever do arise later on.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@vezenovm vezenovm requested a review from a team October 30, 2025 16:09
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 9c919d4 Previous: 9808525 Ratio
sha512-100-bytes 0.076 s 0.05 s 1.52

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@vezenovm vezenovm merged commit 418d82c into mv/comptime-item-gen-tests Oct 30, 2025
127 checks passed
@vezenovm vezenovm deleted the mv/comptime-source-order-unit-tests branch October 30, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants