chore(frontend): Comptime attribute source order unit tests#10322
Merged
vezenovm merged 1 commit intomv/comptime-item-gen-testsfrom Oct 30, 2025
Merged
chore(frontend): Comptime attribute source order unit tests#10322vezenovm merged 1 commit intomv/comptime-item-gen-testsfrom
vezenovm merged 1 commit intomv/comptime-item-gen-testsfrom
Conversation
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 9c919d4 | Previous: 9808525 | Ratio |
|---|---|---|---|
sha512-100-bytes |
0.076 s |
0.05 s |
1.52 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
jfecher
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Working towards green-light of the Elaborator
Summary*
I made a few tests that check the following attribute orderings:
I noticed we had the
attribute_orderintegration test once I had already started on these unit tests but I thought they would be good to keep either way. Unit tests almost act a complementary to documentation and allow for easier debugging if issues ever do arise later on.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.