chore(brillig_gen): Brillig artifact display for unit testing #10165
chore(brillig_gen): Brillig artifact display for unit testing #10165vezenovm merged 9 commits intogd/brillig_gen_greenlight3from
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 80e96ff | Previous: b5ece4a | Ratio |
|---|---|---|---|
sha512-100-bytes |
0.071 s |
0.059 s |
1.20 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: a59adf9 | Previous: b5ece4a | Ratio |
|---|---|---|---|
test_report_zkpassport_noir-ecdsa_ |
3 s |
2 s |
1.50 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 45430f1 | Previous: b5ece4a | Ratio |
|---|---|---|---|
rollup-tx-base-private |
23.78 s |
18.4 s |
1.29 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
1 participant
Description
Problem*
Resolves #10130 (review)
Summary*
I implemented the
BrilligArtifactdisplay mentioned in #10130 (review). I also migrated over the Brillig gen binary unit tests to show the benefits in checking the display of a single Brillig artifact. The binary unit tests are now much more self contained and less reliant on changes elsewhere in the compiler except for the code gen of the instruction in the test itself.The remaining tests in #10130 should be switched over to use the
BrilligArtifactdisplay. We should then have separate tests with comments like inbrillig_addspecifically for testing entry point linking.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.