chore: typos and some refactors in acvm/src/pwg/mod.rs

[michaeljklein]

Description

Problem*

Summary*

• Typos and updating some comments
• Consider adding a test for ACVM AcirMainCallAttempted error #10053
• Deduplicating documentation for Opcode here and here
• ExpressionHasTooManyUnknowns is specific for expression solver #10052
• Removing .clone() from ACVM::solve

  noir/acvm-repo/acvm/src/pwg/mod.rs

  Line 501 in 4a54015

  self.status.clone()

• self.current_opcode() util function
• Refactoring solve_brillig_call_opcode and solve_call_opcode to accept the opcode that’s already been indexed to avoid having an unreachable case

  noir/acvm-repo/acvm/src/pwg/mod.rs

  Line 530 in 4a54015

  Opcode::BrilligCall { .. } => match self.solve_brillig_call_opcode() {

Additional Context

Documentation*

Check one:

• No documentation needed.
• Documentation included in this PR.
• [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt on default settings.

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: bc5da8e	Previous: b5cbbae	Ratio
rollup-block-root-single-tx	0.003 s	0.002 s	1.50
sha512-100-bytes	0.093 s	0.062 s	1.50

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: 519fd4f	Previous: 84d900d	Ratio
test_report_zkpassport_noir-ecdsa_	3 s	2 s	1.50

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

[TomAFrench]

There's a mystery clone which doesn't seem necessary to me.