fix: Just use first circuit report in gates diff test#1
Merged
TomAFrench merged 8 commits intonoir-lang:mainfrom Apr 5, 2024
Merged
fix: Just use first circuit report in gates diff test#1TomAFrench merged 8 commits intonoir-lang:mainfrom
TomAFrench merged 8 commits intonoir-lang:mainfrom
Conversation
5 tasks
…ter gate report wwill fail with these changes
Contributor
Author
|
@TomAFrench this now passes on noir-lang/noir#4719. I was thinking we could merge this PR, I switch to using a commit on the main branch, then make a follow-up on Noir and here that switches back to using |
Member
|
Yep, looks like a good plan to me. |
TomAFrench
pushed a commit
that referenced
this pull request
Apr 25, 2024
Temp check using same content
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.