Merged
Conversation
Member
|
Can you add a test to this repository which checks the behaviour of this? |
Collaborator
Author
|
Oh good point. I'll use the RSA one. |
Collaborator
Author
|
Hmmm... actually, using the RSA one would just bring most of the RSA lib into bignum. I don't know how to distill a test so complex into a smaller test with no dependencies. |
Contributor
|
I'm writing a test now that only passes the output that was making the bug happen to a test directly |
iAmMichaelConnor
commented
Nov 6, 2024
Collaborator
Author
iAmMichaelConnor
left a comment
iAmMichaelConnor
left a comment
There was a problem hiding this comment.
Thanks for this! Just a couple of nits.
Eventually we'll need detailed tests of each function, if we want this thing to pass an audit.
Contributor
|
formatter check is ok on my box but fails on te CI |
Collaborator
Author
|
Are you using nargo v0.36.0 to format? I think that's the version you need to use, to match the CI tests. |
kashbrti
approved these changes
Nov 6, 2024
Merged
TomAFrench
added a commit
that referenced
this pull request
Nov 8, 2024
* main: feat: remove generic parameter from the `BigNum` trait (#44) fix: fix broken tests in `runtime_bignum_test.nr` (#39) feat: remove a bunch of unnecessary bytecode from unconstrained ops (#50) fix: Fix barrett reduction bug (#51) feat: optimize brillig execution of `split_X_bits` functions (#47)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the test failing in noir_rsa. Thanks to Zac for spotting the bug.
cc @kashbrti