fix: remove as_array call for which N cannot be deduced#180
Merged
TomAFrench merged 2 commits intomainfrom May 27, 2025
Merged
Conversation
TomAFrench
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
Towards noir-lang/noir#8686
Summary
I'm not sure how this compiled before noir-lang/noir#8686: the
as_arraycall converted the slice to an array, then I think with implicit rules it was converted back to a slice. But... what's the size of that intermediate array? It can't be deduced. Removing theas_arraycall fixes this, as I think it was never needed (and I think the comment on top of the function saying we can't return slice might be outdated).Additional Context
PR Checklist
cargo fmton default settings.