fix: fix the from::<Field> logic when the MOD_BITS is the same as the native field bitsize #172
Merged
Conversation
TomAFrench
pushed a commit
to noir-lang/noir_bigcurve
that referenced
this pull request
May 12, 2025
Contributor
|
@TomAFrench, I'll open another PR that adds benchmarks for the |
2 tasks
TomAFrench
commented
May 13, 2025
kashbrti
changed the title
from::<Field> logic when the MOD_BITS is the same as the native field bitsize
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Member
Author
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This PR pulls out a testcase which is failing in noir-lang/noir_bigcurve#46. We're calling
::from(4)on a number of different fields so there's something specific to bls12_377 which is causing an issue here.Additional Context
PR Checklist*
cargo fmton default settings.