feat!: implementing BignumTrait for each type using metaprogramming#151
Merged
TomAFrench merged 31 commits intomainfrom Apr 14, 2025
Merged
feat!: implementing BignumTrait for each type using metaprogramming#151TomAFrench merged 31 commits intomainfrom
BignumTrait for each type using metaprogramming#151TomAFrench merged 31 commits intomainfrom
Conversation
TomAFrench
reviewed
Mar 25, 2025
added 2 commits
March 25, 2025 17:04
kashbrti
commented
Mar 25, 2025
Merged
2 tasks
TomAFrench
reviewed
Apr 8, 2025
BignumTrait for each type using metaprogramming
Contributor
Author
|
@TomAFrench, this PR will have significant changes to the interface. Should I update the ReadMe accordingly? |
Member
|
Yeah, we'll need to update the readme to account for these changes. Please do. |
Member
|
I've made a few cleanup changes in the last few commits:
|
Contributor
Author
|
@TomAFrench I'm updating the paramgen as well to work with this version of the lib |
TomAFrench
approved these changes
Apr 14, 2025
TomAFrench
approved these changes
Apr 14, 2025
25f9a8d to
ce18d6e
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We move the
BigNumTraitimpls into a compttime macro.For each
BigNumtype that we construct, we call this macro to implement all the functions in the traitwith the correct generics.
Problem*
Resolves
#142
Summary*
Additional Context
PR Checklist*
cargo fmton default settings.