This repository was archived by the owner on Aug 22, 2023. It is now read-only.
fix: WASM provided by nix build of barretenberg#24
Merged
Conversation
added 16 commits
April 26, 2023 12:16
phated
suggested changes
Apr 26, 2023
Contributor
phated
left a comment
phated
left a comment
There was a problem hiding this comment.
This is a great solution. We need to figure out how to pin bb to the commit noir uses though, perhaps using the lockfile?
- Barretenberg pinned in nix-barretenberg.yml - Barretenberg artfcats uploaded to be shared across workflows - system specific workflows triggered by workflow_run - sucess
phated
reviewed
Apr 27, 2023
TomAFrench
reviewed
Apr 28, 2023
phated
suggested changes
Apr 28, 2023
Contributor
phated
left a comment
phated
left a comment
There was a problem hiding this comment.
Question about your choice about an unofficial action when an official one exists. Maybe there is a reason we can't use official version?
phated
suggested changes
Apr 28, 2023
Contributor
phated
left a comment
phated
left a comment
There was a problem hiding this comment.
Let's add this comment to each workflow.
phated
approved these changes
Apr 28, 2023
Contributor
phated
left a comment
phated
left a comment
There was a problem hiding this comment.
We need to update Noir to dispatch to this new workflow.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
#23
Resolves #
Description
Switching Noir to barretenberg upstream introduced requirement for Barretenberg WASM to be located at
$BARRETENBERG_BIN_DIR. Absence of this variable breaks builds.Summary of changes
libbarretenberg-wasm32 is built by nix from upstream AztecProtocol/barretenberg, uploaded to artifacts and later downloaded and reused by workflows.
Dependency additions / changes
libbarretenberg-wasm32
Test additions / changes
N/A
Checklist
cargo fmtwith default settings.Documentation needs
Additional context