change lib omp link lib name + fixes to stdlib#5
Merged
vezenovm merged 5 commits intokw/noir-dslfrom Dec 9, 2022
Merged
Conversation
This was referenced Dec 8, 2022
phated
pushed a commit
that referenced
this pull request
Feb 1, 2023
fix(flake): Use musl for linux cross-compile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
nargowould not even build in the CI. I changed the link for non ARM based linux to useomp5rather thanomp. I held off on changing the linker forARM_LINUXbut we should probably test this and change for ARM_LINUX build as well before merging. It looks that reason nargo was failing in the CI is that ubuntu-latest requires theomp5flag rather thanomp. In order to build on my local machine I needed theompflag. We have changed the CI build to use ubuntu-20.04 as in this PR (noir-lang/noir#565), so I switched the libomp link to useomp. We can make the change to discern between ubuntu versions once we plan to upgrade the CI to use ubuntu-latest. For now, I think keeping the link name asompis safest.This PR also makes a couple fixes to std_lib funcs and DSL glue that was causing issues with Noir.