This repository was archived by the owner on Apr 9, 2024. It is now read-only.
Closed
Conversation
vezenovm
approved these changes
Aug 22, 2023
Member
|
Do we want to turn the assert into an error and have this be a |
Contributor
Author
This package doesn't have errors 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
While working on noir-lang/noir#2373, I noticed that we have code that converts a
FieldElementinto acharso we can collect them into aString. This adds a properFromimplementation so we don't need the custom code like https://github.com/noir-lang/noir/blob/master/crates/noirc_abi/src/lib.rs#L394-L399Additional Context
PR Checklist*
cargo fmton default settings.