Skip to content
This repository was archived by the owner on Apr 9, 2024. It is now read-only.

feat: Implement Char from FieldElement#504

Closed
phated wants to merge 1 commit intomasterfrom
phated/char-from-fieldelement
Closed

feat: Implement Char from FieldElement#504
phated wants to merge 1 commit intomasterfrom
phated/char-from-fieldelement

Conversation

@phated
Copy link
Contributor

@phated phated commented Aug 22, 2023

Description

Problem*

Resolves

Summary*

While working on noir-lang/noir#2373, I noticed that we have code that converts a FieldElement into a char so we can collect them into a String. This adds a proper From implementation so we don't need the custom code like https://github.com/noir-lang/noir/blob/master/crates/noirc_abi/src/lib.rs#L394-L399

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@phated phated requested review from kevaundray and vezenovm August 22, 2023 19:49
@TomAFrench
Copy link
Member

Do we want to turn the assert into an error and have this be a TryFrom? (The unwrap can be left as is as it should never trigger).

@phated
Copy link
Contributor Author

phated commented Aug 22, 2023

Do we want to turn the assert into an error and have this be a TryFrom? (The unwrap can be left as is as it should never trigger).

This package doesn't have errors 🤷

@TomAFrench TomAFrench closed this Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants