This repository was archived by the owner on Apr 9, 2024. It is now read-only.
Conversation
Contributor
Author
|
|
Contributor
|
Can you diagnose the issue to see if it is fixed by this change? |
Contributor
Author
|
this will return a i think i can add tried to change the error message once this is updated to noir |
Contributor
|
Closing as this is fixed as per: noir-lang/noir#2475 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I don't know if this will fully resolve the issue. if the issue persists, i'll also change the code here
https://github.com/noir-lang/noir/blob/master/crates/noirc_evaluator/src/ssa/acir_gen/acir_ir/acir_variable.rs#L367-L382
https://github.com/noir-lang/noir/blob/master/crates/noirc_evaluator/src/ssa/acir_gen/acir_ir/acir_variable.rs#L203-L231
Problem*
Related to noir-lang/noir#2149
Summary*
Additional Context
PR Checklist*
cargo fmton default settings.