This repository was archived by the owner on Apr 9, 2024. It is now read-only.
Split off errors from OpcodeResolution#39
Merged
kevaundray merged 3 commits intonoir-lang:masterfrom Dec 27, 2022
Merged
Conversation
Contributor
|
haha was thinking of doing something similar! This looks good to me overall, I've opened an issue re UnknownError, but its not a blocker for this, so happy to merge |
kevaundray
approved these changes
Dec 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the changes described in noir-lang/noir#520 (comment).
This is sensible imo as
OpcodeResolutiondoesn't make sense for a circuit-level function such asPartialWitnessGenerator.solve(what does "Skip" mean when solving a circuit?)OpcodeResolutionvariants to be able to separate success vs failure.I've lumped in a change to simplify
BlackBoxFuncCallin the last commit which improves readability imo, happy to revert this if this is unwanted.