Skip to content
This repository was archived by the owner on Apr 9, 2024. It is now read-only.

feat!: remove ComputeMerkleRoot opcode#296

Merged
kevaundray merged 3 commits intomasterfrom
remove-merkle-opcode
May 19, 2023
Merged

feat!: remove ComputeMerkleRoot opcode#296
kevaundray merged 3 commits intomasterfrom
remove-merkle-opcode

Conversation

@TomAFrench
Copy link
Copy Markdown
Member

@TomAFrench TomAFrench commented May 19, 2023

Related issue(s)

Resolves #295

Description

Summary of changes

This PR removes the ComputeMerkleRoot opcode.

Dependency additions / changes

(If applicable.)

Test additions / changes

(If applicable.)

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Additional context

(If applicable.)

BEGIN_COMMIT_OVERRIDE
feat(acir, acvm)!: Remove ComputeMerkleRoot opcode #296
END_COMMIT_OVERRIDE

@TomAFrench TomAFrench requested a review from kevaundray May 19, 2023 08:29
@kevaundray kevaundray added this pull request to the merge queue May 19, 2023
Merged via the queue into master with commit 8b3923e May 19, 2023
@github-actions github-actions Bot mentioned this pull request May 19, 2023
@TomAFrench TomAFrench deleted the remove-merkle-opcode branch May 19, 2023 08:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider removing ComputeMerkleRoot opcode and relying on Noir implementation.

2 participants