This repository was archived by the owner on Apr 9, 2024. It is now read-only.
feat(acir)!: Verify Proof#291
Merged
kevaundray merged 27 commits intomasterfrom Jun 6, 2023
Merged
Conversation
5 tasks
6 tasks
kevaundray
reviewed
May 22, 2023
kevaundray
reviewed
May 22, 2023
kevaundray
reviewed
May 22, 2023
kevaundray
reviewed
May 22, 2023
kevaundray
reviewed
May 22, 2023
kevaundray
reviewed
May 22, 2023
kevaundray
reviewed
May 22, 2023
kevaundray
reviewed
May 22, 2023
kevaundray
reviewed
May 22, 2023
Contributor
kevaundray
left a comment
kevaundray
left a comment
There was a problem hiding this comment.
Generally looks okay -- Some overall questions:
-
Can you give a brief outline as to how this opcode will be used from the user perspective? (I'm trying to understand the rationale behind this interface)
-
The size of the aggregation objects can change depending on the proving system, where do we account for this?
… and comments throughout
vezenovm
commented
May 23, 2023
kevaundray
reviewed
May 25, 2023
This was referenced Jun 6, 2023
kevaundray
approved these changes
Jun 6, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #198
The
acvm-backend-barretenbergPR which implements this can be found here:noir-lang/acvm-backend-barretenberg#207
The relevant Noir PR which implements this and the backend PR can be found here:
noir-lang/noir#1491
Description
Add VerifyProof variant to BlackBoxFunc enum
Summary of changes
(Describe the changes in this PR. Point out breaking changes if any.)
Dependency additions / changes
(If applicable.)
Test additions / changes
(If applicable.)
Checklist
cargo fmtwith default settings.Additional context
(If applicable.)