Skip to content
This repository was archived by the owner on Apr 9, 2024. It is now read-only.

feat(acir)!: replace MerkleMembership opcode with ComputeMerkleRoot#233

Merged
TomAFrench merged 1 commit intomasterfrom
blackbox-return-types
Apr 26, 2023
Merged

feat(acir)!: replace MerkleMembership opcode with ComputeMerkleRoot#233
TomAFrench merged 1 commit intomasterfrom
blackbox-return-types

Conversation

@TomAFrench
Copy link
Copy Markdown
Member

Related issue(s)

Resolves #25

Description

Summary of changes

This PR updates the name of the MerkleMembership opcode to ComputeMerkleRoot. This signals that this opcode will begin to return the merkle root rather than a boolean flag for whether the passed value for the root matches the calculated value.

aztec_backend is ready to switch over to use ComputeMerkleRoot noir-lang/acvm-backend-barretenberg#143 so we can make this change and begin propagating it up to noir.

Dependency additions / changes

(If applicable.)

Test additions / changes

(If applicable.)

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Additional context

(If applicable.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change MerkleCheckMembership opcode to ComputeRoot

2 participants