This repository was archived by the owner on Oct 31, 2023. It is now read-only.
Merged
Conversation
Contributor
Author
|
Chatted with @kevaundray, who said that the published 0.1.0 version should be a compatible version. So I changed this PR to use the published version because it is cleaner. |
5 tasks
kevaundray
approved these changes
Jan 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the
acvmdependency from the noir repo and with theacvmfrom its standalone repo.This dependency currently can't be downloaded on a fresh install because the
7460dda929130589bccfd6619f9409834b72a135commit was part of noir-lang/noir#551 but that branch was deleted—so a fresh clone ofnoir-lang/noirdoesn't include the commit.@vezenovm suggested that we point to the https://github.com/noir-lang/acvm repository now that it has been split from the noir repo; however, there has been a lot of changes to the project. I've pinned the project to the same commit as the final, shared commit: noir-lang/noir@c15c9da