This repository was archived by the owner on Oct 31, 2023. It is now read-only.
chore: Replace wasmer uint8view with view calls#197
Closed
phated wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
This is actually flagged as |
Member
|
Seems like this is superceded by #208? |
Contributor
Author
|
Yep! Wasmer3 fixes this stuff in a much better way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the usage of wasmer's
memory.uint8view()function and replaces it withmemory.view(). It seems that the return type ofuint8viewdiffers by platform, butviewis consistent.My experiments indicate that these implementations will compile on native or wasm32 targets, but I'm leaving it a draft until that can be proven by an actual wasm32 build.