Skip to content
This repository was archived by the owner on Oct 31, 2023. It is now read-only.

chore: add SchnorrSignature struct#170

Closed
TomAFrench wants to merge 1 commit intomasterfrom
schnorr-signature
Closed

chore: add SchnorrSignature struct#170
TomAFrench wants to merge 1 commit intomasterfrom
schnorr-signature

Conversation

@TomAFrench
Copy link
Copy Markdown
Member

This helps avoid us having to merge and split the signature element arrays a couple of times, avoiding the situation where SchnorrConvert is thrown in #151. It also motivates removal of the SchnorrSlice error variant .

@TomAFrench TomAFrench requested a review from phated May 9, 2023 16:24
@phated
Copy link
Copy Markdown
Contributor

phated commented May 9, 2023

These errors stemmed from us trying to construct a "signature" when we always needed a sig_s and sig_e. Instead of trying to construct & deconstruct all over the backend, I've instead just using sig_s and sig_e everywhere. The only place this had significant impact was in the Circuit -> ConstraintSystem conversion, but that uses iterators so it was fine too.

Superseded by 8c56b11 in #151

@phated phated closed this May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants