agents: fix crash accessing cont prof queue #348
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughA static callback function in the gRPC agent implementation was updated to include an additional null check. Now, the function returns early if either the agent pointer or its internal profile queue is null, enhancing safety before attempting to enqueue profile data. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
RafaelGSS
approved these changes
Jul 24, 2025
On runtime shutdown, when continuous profiling is enabled, it can happen that we try access `GrpcAgent::cont_prof_queue_` when it has already being reset, thus crashing the process.
santigimeno
force-pushed
the
santi/fix_cont_prof_crash
branch
from
4163c74 to
4a13325
Compare
santigimeno
added a commit
that referenced
this pull request
Aug 6, 2025
On runtime shutdown, when continuous profiling is enabled, it can happen that we try access `GrpcAgent::cont_prof_queue_` when it has already being reset, thus crashing the process. PR-URL: #348 Reviewed-By: Rafael Gonzaga <[email protected]>
Member
Author
|
Landed in 7cd0229 |
santigimeno
added a commit
that referenced
this pull request
Aug 25, 2025
On runtime shutdown, when continuous profiling is enabled, it can happen that we try access `GrpcAgent::cont_prof_queue_` when it has already being reset, thus crashing the process. PR-URL: #348 Reviewed-By: Rafael Gonzaga <[email protected]>
santigimeno
added a commit
that referenced
this pull request
Aug 26, 2025
On runtime shutdown, when continuous profiling is enabled, it can happen that we try access `GrpcAgent::cont_prof_queue_` when it has already being reset, thus crashing the process. PR-URL: #348 Reviewed-By: Rafael Gonzaga <[email protected]> PR-URL: #359 Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On runtime shutdown, when continuous profiling is enabled, it can happen that we try access
GrpcAgent::cont_prof_queue_when it has already being reset, thus crashing the process.Summary by CodeRabbit