agents: fix crash in StatsDAgent #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevnorris
approved these changes
Nov 27, 2023
trevnorris
force-pushed
the
node-v20.x-nsolid-v5.x
branch
from
1a1236e
to
b2c1bb3
Compare
With some specific udp send errors, it's not possible to retrieve the peername. Handle this case to avoid crashes. Fixes: #31 PR-URL: #32 Reviewed-by: Trevor Norris <[email protected]>
santigimeno
force-pushed
the
santi/fix_crash_peername
branch
from
cf1a376
to
5a47d7e
Compare
santigimeno
added a commit
that referenced
this pull request
Dec 6, 2023
With some specific udp send errors, it's not possible to retrieve the peername. Handle this case to avoid crashes. Fixes: #31 PR-URL: #32 Reviewed-by: Trevor Norris <[email protected]>
trevnorris
pushed a commit
that referenced
this pull request
Dec 7, 2023
With some specific udp send errors, it's not possible to retrieve the peername. Handle this case to avoid crashes. Fixes: #31 PR-URL: #32 Reviewed-by: Trevor Norris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some specific udp send errors, it's not possible to retrieve the peername. Handle this case to avoid crashes.
Fixes: #31