agents: fix grpc keepalive configuration #265
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase a bit the keepalive period and timeout. Also, set `GRPC_ARG_HTTP2_MAX_PINGS_WITHOUT_DATA` to `0` to make sure we can send `PING` frames indefinitelly even if there's no activity in the channel, to make sure the channel is up for as long as possible.
RafaelGSS
approved these changes
Feb 10, 2025
juanarbol
approved these changes
Feb 10, 2025
santigimeno
added a commit
that referenced
this pull request
Feb 11, 2025
Increase a bit the keepalive period and timeout. Also, set `GRPC_ARG_HTTP2_MAX_PINGS_WITHOUT_DATA` to `0` to make sure we can send `PING` frames indefinitelly even if there's no activity in the channel, to make sure the channel is up for as long as possible. PR-URL: #265 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Member
Author
|
Landed in 30f54e6 |
santigimeno
added a commit
that referenced
this pull request
Feb 12, 2025
Increase a bit the keepalive period and timeout. Also, set `GRPC_ARG_HTTP2_MAX_PINGS_WITHOUT_DATA` to `0` to make sure we can send `PING` frames indefinitelly even if there's no activity in the channel, to make sure the channel is up for as long as possible. PR-URL: #265 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
santigimeno
added a commit
that referenced
this pull request
Feb 14, 2025
Increase a bit the keepalive period and timeout. Also, set `GRPC_ARG_HTTP2_MAX_PINGS_WITHOUT_DATA` to `0` to make sure we can send `PING` frames indefinitelly even if there's no activity in the channel, to make sure the channel is up for as long as possible. PR-URL: #265 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
santigimeno
added a commit
that referenced
this pull request
Feb 14, 2025
Increase a bit the keepalive period and timeout. Also, set `GRPC_ARG_HTTP2_MAX_PINGS_WITHOUT_DATA` to `0` to make sure we can send `PING` frames indefinitelly even if there's no activity in the channel, to make sure the channel is up for as long as possible. PR-URL: #265 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> PR-URL: #268
santigimeno
added a commit
that referenced
this pull request
Feb 14, 2025
Increase a bit the keepalive period and timeout. Also, set `GRPC_ARG_HTTP2_MAX_PINGS_WITHOUT_DATA` to `0` to make sure we can send `PING` frames indefinitelly even if there's no activity in the channel, to make sure the channel is up for as long as possible. PR-URL: #265 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> PR-URL: #269
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase a bit the keepalive period and timeout.
Also, set
GRPC_ARG_HTTP2_MAX_PINGS_WITHOUT_DATAto0to make sure we can sendPINGframes indefinitelly even if there's no activity in the channel, to make sure the channel is up for as long as possible.