deps: timeDeltas in cpu profiles are signed #254
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, they can take a negative value (don't really know why because supposedly v8 uses a monotonic clock). We don't want to cast them to unsigned to avoid overflows.
santigimeno
force-pushed
the
santi/fix_delta_times
branch
from
0d401be to
86178c3
Compare
santigimeno
added a commit
that referenced
this pull request
Jan 24, 2025
In some cases, they can take a negative value (don't really know why because supposedly v8 uses a monotonic clock). We don't want to cast them to unsigned to avoid overflows. PR-URL: #254 Reviewed-By: Juan José Arboleda <[email protected]>
Member
Author
|
Landed in 0246f46 |
santigimeno
added a commit
that referenced
this pull request
Feb 12, 2025
In some cases, they can take a negative value (don't really know why because supposedly v8 uses a monotonic clock). We don't want to cast them to unsigned to avoid overflows. PR-URL: #254 Reviewed-By: Juan José Arboleda <[email protected]>
santigimeno
added a commit
that referenced
this pull request
Feb 14, 2025
In some cases, they can take a negative value (don't really know why because supposedly v8 uses a monotonic clock). We don't want to cast them to unsigned to avoid overflows. PR-URL: #254 Reviewed-By: Juan José Arboleda <[email protected]>
santigimeno
added a commit
that referenced
this pull request
Feb 14, 2025
In some cases, they can take a negative value (don't really know why because supposedly v8 uses a monotonic clock). We don't want to cast them to unsigned to avoid overflows. PR-URL: #254 Reviewed-By: Juan José Arboleda <[email protected]> PR-URL: #268
santigimeno
added a commit
that referenced
this pull request
Feb 14, 2025
In some cases, they can take a negative value (don't really know why because supposedly v8 uses a monotonic clock). We don't want to cast them to unsigned to avoid overflows. PR-URL: #254 Reviewed-By: Juan José Arboleda <[email protected]> PR-URL: #269
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, they can take a negative value (don't really know why because supposedly v8 uses a monotonic clock). We don't want to cast them to unsigned to avoid overflows.