src: cleanup the RunCommand queues on RemoveEnv #25

santigimeno · 2023-11-16T14:03:42Z

src: change EnvList::promise_tracking_() signature

Pass directly the SharedEnvInst.

src: fix EnvInst::GetCurrent()

Handle the case where the `Environment` is already nullptr.

src: cleanup the RunCommand queues on RemoveEnv

Just to be sure no dangling SharedEnvInst references are left after the
Environment is gone and the EnvInst instance can be deleted.

src: fix SetupArrayBufferExports() declaration

Fixes: #26

Pass directly the SharedEnvInst. PR-URL: #25 Reviewed-by: Santiago Gimeno <[email protected]>

Handle the case where the `Environment` is already nullptr. PR-URL: #25 Reviewed-by: Santiago Gimeno <[email protected]>

Just to be sure no dangling SharedEnvInst references are left after the Environment is gone and the EnvInst instance can be deleted. PR-URL: #25 Reviewed-by: Santiago Gimeno <[email protected]>

PR-URL: #25 Reviewed-by: Santiago Gimeno <[email protected]>

Pass directly the SharedEnvInst. PR-URL: #25 Reviewed-by: Santiago Gimeno <[email protected]>

Handle the case where the `Environment` is already nullptr. PR-URL: #25 Reviewed-by: Santiago Gimeno <[email protected]>

Just to be sure no dangling SharedEnvInst references are left after the Environment is gone and the EnvInst instance can be deleted. PR-URL: #25 Reviewed-by: Santiago Gimeno <[email protected]>

PR-URL: #25 Reviewed-by: Santiago Gimeno <[email protected]>

Pass directly the SharedEnvInst. PR-URL: #25 Reviewed-by: Trevor Norris <[email protected]>

Handle the case where the `Environment` is already nullptr. PR-URL: #25 Reviewed-by: Trevor Norris <[email protected]>

Just to be sure no dangling SharedEnvInst references are left after the Environment is gone and the EnvInst instance can be deleted. PR-URL: #25 Reviewed-by: Trevor Norris <[email protected]>

PR-URL: #25 Reviewed-by: Trevor Norris <[email protected]>

Pass directly the SharedEnvInst. PR-URL: #25 Reviewed-by: Trevor Norris <[email protected]>

Handle the case where the `Environment` is already nullptr. PR-URL: #25 Reviewed-by: Trevor Norris <[email protected]>

Just to be sure no dangling SharedEnvInst references are left after the Environment is gone and the EnvInst instance can be deleted. PR-URL: #25 Reviewed-by: Trevor Norris <[email protected]>

PR-URL: #25 Reviewed-by: Trevor Norris <[email protected]>

Pass directly the SharedEnvInst. PR-URL: #25 Reviewed-by: Trevor Norris <[email protected]>

Handle the case where the `Environment` is already nullptr. PR-URL: #25 Reviewed-by: Trevor Norris <[email protected]>

Just to be sure no dangling SharedEnvInst references are left after the Environment is gone and the EnvInst instance can be deleted. PR-URL: #25 Reviewed-by: Trevor Norris <[email protected]>

PR-URL: #25 Reviewed-by: Trevor Norris <[email protected]>

santigimeno requested a review from trevnorris November 16, 2023 14:03

santigimeno self-assigned this Nov 16, 2023

trevnorris approved these changes Nov 16, 2023

View reviewed changes

santigimeno added 4 commits November 22, 2023 15:24

src: change EnvList::promise_tracking_() signature

209112a

Pass directly the SharedEnvInst. PR-URL: #25 Reviewed-by: Santiago Gimeno <[email protected]>

src: fix EnvInst::GetCurrent()

6f303c7

Handle the case where the `Environment` is already nullptr. PR-URL: #25 Reviewed-by: Santiago Gimeno <[email protected]>

src: cleanup the RunCommand queues on RemoveEnv

be6aea6

Just to be sure no dangling SharedEnvInst references are left after the Environment is gone and the EnvInst instance can be deleted. PR-URL: #25 Reviewed-by: Santiago Gimeno <[email protected]>

src: fix SetupArrayBufferExports() declaration

f16e228

PR-URL: #25 Reviewed-by: Santiago Gimeno <[email protected]>

santigimeno force-pushed the santi/fix_shared_envinst_leak branch from 03690a8 to f16e228 Compare November 22, 2023 14:24

santigimeno merged commit f16e228 into node-v20.x-nsolid-v5.x Nov 22, 2023
15 of 18 checks passed

santigimeno deleted the santi/fix_shared_envinst_leak branch November 22, 2023 14:25

trevnorris pushed a commit that referenced this pull request Nov 30, 2023

src: change EnvList::promise_tracking_() signature

1f2366e

Pass directly the SharedEnvInst. PR-URL: #25 Reviewed-by: Santiago Gimeno <[email protected]>

trevnorris pushed a commit that referenced this pull request Nov 30, 2023

src: fix EnvInst::GetCurrent()

d67a0ba

Handle the case where the `Environment` is already nullptr. PR-URL: #25 Reviewed-by: Santiago Gimeno <[email protected]>

trevnorris pushed a commit that referenced this pull request Nov 30, 2023

src: fix SetupArrayBufferExports() declaration

7e71090

PR-URL: #25 Reviewed-by: Santiago Gimeno <[email protected]>

trevnorris pushed a commit that referenced this pull request Nov 30, 2023

src: change EnvList::promise_tracking_() signature

33c8b29

Pass directly the SharedEnvInst. PR-URL: #25 Reviewed-by: Trevor Norris <[email protected]>

trevnorris pushed a commit that referenced this pull request Nov 30, 2023

src: fix EnvInst::GetCurrent()

2e55267

Handle the case where the `Environment` is already nullptr. PR-URL: #25 Reviewed-by: Trevor Norris <[email protected]>

trevnorris pushed a commit that referenced this pull request Nov 30, 2023

src: fix SetupArrayBufferExports() declaration

f6fd580

PR-URL: #25 Reviewed-by: Trevor Norris <[email protected]>

trevnorris pushed a commit that referenced this pull request Dec 5, 2023

src: change EnvList::promise_tracking_() signature

f2fc8ef

Pass directly the SharedEnvInst. PR-URL: #25 Reviewed-by: Trevor Norris <[email protected]>

trevnorris pushed a commit that referenced this pull request Dec 5, 2023

src: fix EnvInst::GetCurrent()

7649d47

Handle the case where the `Environment` is already nullptr. PR-URL: #25 Reviewed-by: Trevor Norris <[email protected]>

trevnorris pushed a commit that referenced this pull request Dec 5, 2023

src: fix SetupArrayBufferExports() declaration

f4d4d46

PR-URL: #25 Reviewed-by: Trevor Norris <[email protected]>

juanarbol mentioned this pull request Dec 6, 2023

2023-12-06, N|Solid v5.0.1 Iron Release #41

Merged

trevnorris pushed a commit that referenced this pull request Dec 7, 2023

src: change EnvList::promise_tracking_() signature

2d187ff

Pass directly the SharedEnvInst. PR-URL: #25 Reviewed-by: Trevor Norris <[email protected]>

trevnorris pushed a commit that referenced this pull request Dec 7, 2023

src: fix EnvInst::GetCurrent()

5ab8629

Handle the case where the `Environment` is already nullptr. PR-URL: #25 Reviewed-by: Trevor Norris <[email protected]>

trevnorris pushed a commit that referenced this pull request Dec 7, 2023

src: fix SetupArrayBufferExports() declaration

846637d

PR-URL: #25 Reviewed-by: Trevor Norris <[email protected]>

juanarbol mentioned this pull request Dec 7, 2023

2023-12-07, N|Solid v5.0.1 Hydrogen Release #42

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src: cleanup the RunCommand queues on RemoveEnv #25

src: cleanup the RunCommand queues on RemoveEnv #25

santigimeno commented Nov 16, 2023 •

edited

Loading

src: cleanup the RunCommand queues on RemoveEnv #25

src: cleanup the RunCommand queues on RemoveEnv #25

Conversation

santigimeno commented Nov 16, 2023 • edited Loading

santigimeno commented Nov 16, 2023 •

edited

Loading