Add a timeout to fetch() + configurable environment variable
#24
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmuellr
reviewed
Oct 24, 2018
juliangruber
suggested changes
Oct 25, 2018
Co-Authored-By: bnb <[email protected]>
|
LGTM @juliangruber! As a note, I used the all caps because of a similar environment variable in the GraphQL code 😅 |
oops! consistency :D |
pmuellr
reviewed
Oct 25, 2018
| // Setting up a timeout to be used with fetch() – will use the NCM_TIMEOUT environment | ||
| // variable or default to 2 minutes (120 seconds / 120000 milliseconds) | ||
| const timeout = process.env.NCM_TIMEOUT | ||
| ? Number(process.env.NCM_TIMEOUT) * 1000 |
There was a problem hiding this comment.
still need to check for a non-numeric string in the env var:
$ node -p 'Number("foo") * 1000'
NaNtimeout will end up being a NaN in that case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a timeout to the
fetch()call in/bin/ncm-ci.js. Also adds theNCM_TIMEOUTenvironment variable, which can be used to set a custom timeout time (2 minutes by default).