added task to uninstall before installing new version - allows change… #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of version on reprovisioning scripts
kitsunde
reviewed
Sep 30, 2016
| @@ -26,5 +26,8 @@ | |||
| src: etc/apt/preferences.d/deb_nodesource_com_node.pref.2 | |||
| dest: /etc/apt/preferences.d/deb_nodesource_com_node.pref | |||
|
|
|||
| - name: Uninstall existing installations of Node.js | |||
| apt: name=nodejs state=absent | |||
|
|
|||
There was a problem hiding this comment.
Is there some way of making this check it is necessary? It would be way too excessive to have node reinstall itself every time we run through ansible.
There was a problem hiding this comment.
Since posting this issue I've created my own Ansible implementation of NVM and I no longer use nodesource.
If you were to do so, you should check for an existing install, register a variable with the currently installed version and provide some logic to determine if it should be uninstalled first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow function to change versions of Node.js if the nodejs version variable changes to allow seamless porting between the available versions.
Tested with DrupalVM on provision, and reprovision between both versions, and has no effect when install hasn't been previously executed from the playbook.