Add Node Handbook content #105
Conversation
|
@flaviocopes Congratulations on your first PR to this initiative! 💥 We're super happy to have all the content to review. The review for this PR may take slightly more time than is typical, being a 5000+ line PR 👀 Thanks for starting to contribute here! |
|
@flaviocopes you are amazing 🎉 I'll be sure to do a closer review over the weekend, but at cursory glance this is brilliant. @mjordancodes, interested in siccing your army of new developers on this branch for content review as well? Have them comment on anything they're confused by, think could be re-structured, or just when they really like something! We can all work to integrate the feedback afterwords. Having the new-developer eyes on content targeted for them will be very helpful. We'll also take a pass at identifying images that can be re-done in the new illustration style we're pursuing for the site. I'll have Joey (designer) take a look at that in the next week or so. This PR can land before that happens. |
amiller-gh
added
wr-agenda
|
@amiller-gh --> Just saw this. Sharing on the slack group now. Will bug students in person when I see them again on Wednesday |
|
@ZibbyKeaton This is the PR that contributes Getting Started content to the project. 🙌🏽 Thanks @flaviocopes! 💖 |
| }) | ||
| apples.forEach(fruit => { | ||
| console.count(fruit) | ||
| }) |
There was a problem hiding this comment.
I think using semicolons at the end of each statement for at least the larger code blocks is in the best interest for a beginner going through these guides. Although there are no changes in the behavior here, I think it's best for a programmer to use semicolons while writing Js Code
@bnb Your thoughts on this
|
@flaviocopes Brilliant job. Can't appreciate enough. |
Co-Authored-By: flaviocopes <[email protected]>
|
Thanks @Flowkrad for all those suggestions! |
|
@flaviocopes You are AMAZING 🎉 |
|
Thank you @amiller-gh, I'm super happy this was merged 😀 🎉 |
After @amiller-gh got in touch I started moving content from nodehandbook.com to this PR, adapting the content to suit the Node.js website.
I removed some fancy banner images I used in the original content (not suitable here), removed internal links that pointed to my blog, removed opinionated things and some content not appropriate.
Let me know what you think!