Fix bufused when there are more entries to be read #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the bufused value to be that of the buffer length (buf_len) when there are more entries to be read. Currently what is happening is that if another directory entry cannot be written to the buffer then the current value of bufused is being "returned", which indicates that all directory entries have been written to the buffer which is not the case. Fixes: nodejs#174
Remove unused variables from test.
cjihrig
approved these changes
Sep 5, 2022
Remove commented out fprintf statement.
|
Landed in 92caba8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the
bufusedvalue to be that of the buffer length(
buf_len) when there are more entries to be read.Currently what is happening is that if another directory entry cannot
be written to the buffer then the current value of
bufusedis being"returned", which indicates that all directory entries have been
written to the buffer which is not the case.
Fixes: #174
Using the provided reproducer in #174 running it produces:
This does not match the expected count of
300, but if we remove the pipe and the word count command and look at the output of the command we can see that there is an extra line in the output which will be included in the count.