feat(dep-manager): introduce
#270
Closed
+196
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AugustinMauroy
added
the
awaiting reviewer
Member
|
A very popular library that does something similar is ni, but if you only need the part that detects the package manager, you can use package-manager-detector, which is what ni uses internally. It might be worth taking a look at how they implemented it, since there are some edge cases covered there. We could handle the same scenarios ourselves, or use the library directly if you prefer. |
Member
Author
|
Why not good idea never heard of theses package. But I need to see if there are compatible with JSSG |
avivkeller
requested changes
Nov 23, 2025
Comment on lines
+8
to
+22
| export const detectPackageManager = (): 'npm' | 'yarn' | 'pnpm' => { | ||
| try { | ||
| console.log('Checking for yarn.lock file'); | ||
| accessSync('yarn.lock'); | ||
| console.log('Detected yarn.lock file'); | ||
| return 'yarn'; | ||
| } catch {} | ||
|
|
||
| try { | ||
| accessSync('pnpm-lock.yaml'); | ||
| return 'pnpm'; | ||
| } catch {} | ||
|
|
||
| return 'npm'; | ||
| }; |
Member
There was a problem hiding this comment.
Can't we use a dependency that does this for us?
Comment on lines
+24
to
+44
| export const removeDependency = ( | ||
| dependency: string, | ||
| stdio: StdioOptions = 'inherit', | ||
| ): void => { | ||
| const packageManager = detectPackageManager(); | ||
| let command = ''; | ||
|
|
||
| switch (packageManager) { | ||
| case 'npm': | ||
| command = `npm uninstall ${dependency}`; | ||
| break; | ||
| case 'yarn': | ||
| command = `yarn remove ${dependency}`; | ||
| break; | ||
| case 'pnpm': | ||
| command = `pnpm remove ${dependency}`; | ||
| break; | ||
| } | ||
|
|
||
| execSync(command, { stdio }); | ||
| }; |
Member
There was a problem hiding this comment.
This is vulnerable to Remote Code Execution via a malicious package name.
Member
Author
|
close in favor of #256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.