Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: request body.body regression #955

Merged
merged 6 commits into from
Aug 13, 2021
Merged

fix: request body.body regression #955

merged 6 commits into from
Aug 13, 2021

Conversation

ronag
Copy link
Member

@ronag ronag commented Aug 13, 2021

@mcollina
Copy link
Member

seems CI is not happy

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2021

Codecov Report

Merging #955 (616a4c2) into main (d4f6a2f) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #955      +/-   ##
==========================================
- Coverage   80.72%   80.64%   -0.08%     
==========================================
  Files          35       35              
  Lines        3304     3467     +163     
==========================================
+ Hits         2667     2796     +129     
- Misses        637      671      +34     
Impacted Files Coverage Δ
index.js 100.00% <100.00%> (ø)
lib/api/readable.js 86.11% <100.00%> (+3.86%) ⬆️
lib/client.js 97.82% <0.00%> (-0.26%) ⬇️
lib/fetch/index.js 54.90% <0.00%> (+4.00%) ⬆️
lib/fetch/util.js 47.05% <0.00%> (+30.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4f6a2f...616a4c2. Read the comment docs.

@ronag ronag merged commit a4c29bc into main Aug 13, 2021
@ronag ronag deleted the request-body-regression branch October 28, 2021 08:10
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
* fix: request body.body regression

Refs: nodejs#928 (comment)

* fixup

* fixup

* fixup

* fixup

* fixup
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
* fix: request body.body regression

Refs: nodejs#928 (comment)

* fixup

* fixup

* fixup

* fixup

* fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants