Repository navigation
fix(session cache): fix bug in tls session caching - #5882
Merged
Merged
Conversation
Spotted this one by accident. In the tls session cache, nodejs#5102 added logic to remove dead entries and make room, but the check used an early return that short circuited the cache operation. Signed-off-by: James M Snell <jasnell@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5882 +/- ##
=======================================
Coverage 93.90% 93.91%
=======================================
Files 110 110
Lines 39901 39907 +6
=======================================
+ Hits 37470 37479 +9
+ Misses 2431 2428 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
metcoder95
approved these changes
Sep 24, 2026
Merged
3 of 7 tasks
mcollina
pushed a commit
that referenced
this pull request
Oct 15, 2026
Merged
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
tls session cache
Rationale
Spotted this one by accident. In the tls session cache, #5102 added logic to remove dead entries and make room, but the check used an early return that short circuited the cache operation.
Changes
Features
Bug Fixes
N/A
Breaking Changes and Deprecations
N/A
Status