test: absorb h2 stream timeout resets - #5383
Merged
Merged
Conversation
Signed-off-by: marko1olo <barsukdana@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5383 +/- ##
==========================================
+ Coverage 93.25% 93.26% +0.01%
==========================================
Files 110 110
Lines 36752 36752
==========================================
+ Hits 34274 34278 +4
+ Misses 2478 2474 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
@AliMahmoudDev @marko1olo it seems this is part of a Bot/automation campaign. Slow down and review all changes manually. Purely automated contributions are not welcomed. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
issue-5137timeout regression test.RetryAgentinside the test body so teardown happens before node:test reports late asynchronous activity.Why
A macOS Node 25 CI run reported
test/issue-5137.jsgenerating asynchronous activity after the test ended withError: read ECONNRESET. The test intentionally lets every HTTP/2 stream time out, so client-side resets are expected teardown noise rather than the regression under test.Test
node --test test\issue-5137.js1..5 | ForEach-Object { node --test test\issue-5137.js }npx eslint --no-cache test\issue-5137.jsgit diff --checkAI-assisted contribution: implementation and verification were performed with OpenAI Codex under my direction.