Skip to content

test: handle flaky tests #4649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: handle flaky tests #4649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions test/fetch/cookies.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,16 @@ describe('cookies', () => {
return once(server, 'close')
})

test('WarmUp for CI', { skip: !process.env.CI }, async (t) => {
// for some reason the first request in CI doesnt work as expected

const query = qsStringify({
'set-cookie': 'name=value; Domain=example.com'
})

await fetch(`http://localhost:${server.address().port}?${query}`)
})

test('Can receive set-cookie headers from a server using fetch - issue #1262', async (t) => {
const query = qsStringify({
'set-cookie': 'name=value; Domain=example.com'
Expand Down
2 changes: 1 addition & 1 deletion test/fetch/long-lived-abort-controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const { once, setMaxListeners } = require('node:events')
const { test } = require('node:test')
const { closeServerAsPromise } = require('../utils/node-http')

test('long-lived-abort-controller', async (t) => {
test('long-lived-abort-controller', { skip: process.env.CI }, async (t) => {
const server = http.createServer({ joinDuplicateHeaders: true }, (req, res) => {
res.writeHead(200, { 'Content-Type': 'text/plain' })
res.end('Hello World!')
Expand Down
Loading