fix: memory leak in Agent #4425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Member
|
Can you add a unit test? |
Contributor
Author
|
Added a unit test for the referenced issue. |
metcoder95
reviewed
Aug 18, 2025
metcoder95
reviewed
Aug 18, 2025
Member
metcoder95
left a comment
metcoder95
left a comment
There was a problem hiding this comment.
Your report is correct, but I’m not 100% what’s the side effect of it; can you take a look? I’ll try to take a look at it Tomorrow or later this week
Member
|
There are relevant regressions |
hexchain
force-pushed
the
fix-4424
branch
2 times, most recently
from
3f6db98 to
e32d948
Compare
Contributor
Author
|
I've pushed a new version to fix the tests. Some other changes worth noting:
|
metcoder95
approved these changes
Aug 20, 2025
Closed
7 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
#4424
Changes
Instead of using
originfrom theconnectanddisconnectevents, track client using the original key.Features
N/A
Bug Fixes
#4424
Breaking Changes and Deprecations
N/A
Status