Skip to content

cache: ensure vary & revalidation headers are case-insensitive #4112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2025
Merged

cache: ensure vary & revalidation headers are case-insensitive #4112

merged 2 commits into from
Mar 27, 2025

Conversation

@alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Mar 21, 2025 •
edited
Loading

Closes #4103

This relates to...

Changes

  • add/extend cache tests for mixed-case headers:
    • Vary
    • If-Modified-Since
    • If-None-Match

Features

N/A

Bug Fixes

Breaking Changes and Deprecations

Status

@mcollina
Copy link
Member

looks good, what's missing?

@alxndrsn
Copy link
Contributor Author

looks good, what's missing?

Thanks for the nudge - I didn't realise this was in draft still.

@alxndrsn alxndrsn marked this pull request as ready for review March 24, 2025 07:19
mcollina
mcollina approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit fa959b8 into nodejs:main Mar 27, 2025
28 of 31 checks passed
@alxndrsn alxndrsn deleted the cache-case-sensitive branch March 27, 2025 14:19
@renovate renovate bot mentioned this pull request Apr 4, 2025
Merged
1 task
@github-actions github-actions bot mentioned this pull request May 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@metcoder95 metcoder95 metcoder95 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cache can add duplicate if-none-match, if-modified-since & varied headers (case-sensitivity)

3 participants

@alxndrsn @mcollina @metcoder95