-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reduce memory usage in client-h1 #3510
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you modify the fire-and-forget test to do more fetches, then the result is more clear?! before: after: |
mcollina
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ronag
approved these changes
Aug 27, 2024
I've amended the title, as there is no actual leak here. |
This comment was marked as outdated.
This comment was marked as outdated.
github-actions bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
(cherry picked from commit b725457)
Uzlopak
added a commit
that referenced
this pull request
Oct 3, 2024
(cherry picked from commit b725457) Co-authored-by: Aras Abbasi <[email protected]>
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially fixes #2143 ?
tbh... I investigated the heap and saw alot of Timeouts (of our fast timers implementation) dangling(?) with onParserTimeout as callback. I guess when you run it for 6 minutes, like in the reproduction of the reported issue, some of those timeouts keep dangling and get not gc'ed?
Anyhow... this PR seems to reduce the memory usage anyway?!
So please review/take it with a grain of salt.
before:
after: