Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only ref socket when in use #2056

Closed
wants to merge 1 commit into from
Closed

fix: only ref socket when in use #2056

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Apr 11, 2023

@ronag ronag requested a review from mcollina April 11, 2023 07:56
@ronag ronag marked this pull request as ready for review April 11, 2023 07:56
@ronag ronag force-pushed the socket-ref branch 4 times, most recently from 407f470 to 0dea450 Compare April 11, 2023 07:58
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.52 ⚠️

Comparison is base (b20405e) 90.43% compared to head (b202df3) 89.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2056      +/-   ##
==========================================
- Coverage   90.43%   89.92%   -0.52%     
==========================================
  Files          71       63       -8     
  Lines        6199     5715     -484     
==========================================
- Hits         5606     5139     -467     
+ Misses        593      576      -17     
Impacted Files Coverage Δ
lib/core/symbols.js 100.00% <ø> (ø)
lib/client.js 97.53% <100.00%> (-0.02%) ⬇️
lib/core/request.js 98.91% <100.00%> (+0.06%) ⬆️

... and 14 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ronag ronag closed this Apr 11, 2023
@Uzlopak Uzlopak deleted the socket-ref branch February 27, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants