fix: remove unnecessary WeakRef #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's sufficient that the finalizer removes the closure. Fixes: #1926
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2000 +/- ##
==========================================
+ Coverage 90.45% 90.51% +0.06%
==========================================
Files 71 71
Lines 6138 6198 +60
==========================================
+ Hits 5552 5610 +58
- Misses 586 588 +2
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Sorry, after this change, I have a memory leak again with SvelteKit! |
This was referenced Mar 25, 2023
|
Please open a new issue |
|
@ronag okey, I want to first be sure it's undici this time; maybe it's coincident. Sorry, for the mess, it was a stressful situation on production. |
|
No worries, I re-openend the old issue as you suggested. |
5 tasks
7 tasks
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Jul 21, 2023
It's sufficient that the finalizer removes the closure. Fixes: nodejs#1926
kodiakhq bot
referenced
this pull request
in X-oss-byte/Canary-nextjs
Oct 1, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [undici](https://undici.nodejs.org) ([source](https://github.com/nodejs/undici)) | [`5.19.1` -> `5.25.2`](https://renovatebot.com/diffs/npm/undici/5.19.1/5.25.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>nodejs/undici (undici)</summary> ### [`v5.25.2`](https://github.com/nodejs/undici/releases/tag/v5.25.2) [Compare Source](https://github.com/nodejs/undici/compare/v5.25.1...v5.25.2) #### What's Changed - Add Khaf to releasers by [@​mcollina](https://github.com/mcollina) in [https://github.com/nodejs/undici/pull/2276](https://github.com/nodejs/undici/pull/2276) - fix: fix request with readable mode is object by [@​killagu](https://github.com/killagu) in [https://github.com/nodejs/undici/pull/2279](https://github.com/nodejs/undici/pull/2279) - fix loading websockets when node is built w/ --without-ssl by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2282](https://github.com/nodejs/undici/pull/2282) #### New Contributors - [@​killagu](https://github.com/killagu) made their first contribution in [https://github.com/nodejs/undici/pull/2279](https://github.com/nodejs/undici/pull/2279) **Full Changelog**: nodejs/undici@v5.25.1...v5.25.2 ### [`v5.25.1`](https://github.com/nodejs/undici/releases/tag/v5.25.1) [Compare Source](https://github.com/nodejs/undici/compare/v5.25.0...v5.25.1) #### What's Changed - Add publish types script by [@​Ethan-Arrowood](https://github.com/Ethan-Arrowood) in [https://github.com/nodejs/undici/pull/2273](https://github.com/nodejs/undici/pull/2273) **Full Changelog**: nodejs/undici@v5.25.0...v5.25.1 ### [`v5.25.0`](https://github.com/nodejs/undici/releases/tag/v5.25.0) [Compare Source](https://github.com/nodejs/undici/compare/v5.24.0...v5.25.0) #### What's Changed - fix: h2 without body by [@​metcoder95](https://github.com/metcoder95) in [https://github.com/nodejs/undici/pull/2258](https://github.com/nodejs/undici/pull/2258) - ci: remove duplicated runs by [@​metcoder95](https://github.com/metcoder95) in [https://github.com/nodejs/undici/pull/2265](https://github.com/nodejs/undici/pull/2265) - improve documentation of timeouts by making the units clear in all places by [@​mcfedr](https://github.com/mcfedr) in [https://github.com/nodejs/undici/pull/2266](https://github.com/nodejs/undici/pull/2266) - expose websocket in node bundle by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2217](https://github.com/nodejs/undici/pull/2217) - test: fix Fetch/HTTP2 tests by [@​metcoder95](https://github.com/metcoder95) in [https://github.com/nodejs/undici/pull/2263](https://github.com/nodejs/undici/pull/2263) - fix undici when node is built with --without-ssl by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2272](https://github.com/nodejs/undici/pull/2272) - fix: Fix type definition for Client Interceptors by [@​ComradeCow](https://github.com/ComradeCow) in [https://github.com/nodejs/undici/pull/2269](https://github.com/nodejs/undici/pull/2269) - Fix http2 agent by [@​mcollina](https://github.com/mcollina) in [https://github.com/nodejs/undici/pull/2275](https://github.com/nodejs/undici/pull/2275) #### New Contributors - [@​ComradeCow](https://github.com/ComradeCow) made their first contribution in [https://github.com/nodejs/undici/pull/2269](https://github.com/nodejs/undici/pull/2269) **Full Changelog**: nodejs/undici@v5.24.0...v5.25.0 ### [`v5.24.0`](https://github.com/nodejs/undici/releases/tag/v5.24.0) [Compare Source](https://github.com/nodejs/undici/compare/v5.23.0...v5.24.0) #### Notable Changes - feat: Add H2 support by [@​metcoder95](https://github.com/metcoder95) in [https://github.com/nodejs/undici/pull/2061](https://github.com/nodejs/undici/pull/2061) #### What's Changed - build(deps): bump step-security/harden-runner from 2.4.1 to 2.5.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2203](https://github.com/nodejs/undici/pull/2203) - better stack trace for body.json by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2215](https://github.com/nodejs/undici/pull/2215) - allow http & https websocket urls by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2218](https://github.com/nodejs/undici/pull/2218) - build(deps-dev): bump [@​sinonjs/fake-timers](https://github.com/sinonjs/fake-timers) from 10.3.0 to 11.1.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2221](https://github.com/nodejs/undici/pull/2221) - fix: pass ProxyAgent proxy status code error by [@​NBNGaming](https://github.com/NBNGaming) in [https://github.com/nodejs/undici/pull/2162](https://github.com/nodejs/undici/pull/2162) - fix failing test by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2223](https://github.com/nodejs/undici/pull/2223) - docs: update MockPool.md intercept method description by [@​capaj](https://github.com/capaj) in [https://github.com/nodejs/undici/pull/2220](https://github.com/nodejs/undici/pull/2220) - Update wpts by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2226](https://github.com/nodejs/undici/pull/2226) - build(deps): bump github/codeql-action from 2.21.2 to 2.21.5 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2240](https://github.com/nodejs/undici/pull/2240) - build(deps): bump actions/setup-node from 3.6.0 to 3.8.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2237](https://github.com/nodejs/undici/pull/2237) - build(deps): bump fastify/github-action-merge-dependabot from 3.9.0 to 3.9.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2236](https://github.com/nodejs/undici/pull/2236) - build(deps): bump actions/checkout from 3.5.3 to 3.6.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2241](https://github.com/nodejs/undici/pull/2241) - build(deps): bump actions/dependency-review-action from 3.0.6 to 3.0.8 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2238](https://github.com/nodejs/undici/pull/2238) - fix: aborting request with non-object error by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2243](https://github.com/nodejs/undici/pull/2243) - fix: preserve file path when parsing formdata by [@​jimmywarting](https://github.com/jimmywarting) in [https://github.com/nodejs/undici/pull/2245](https://github.com/nodejs/undici/pull/2245) - build(deps-dev): bump tsd from 0.28.1 to 0.29.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2246](https://github.com/nodejs/undici/pull/2246) - Updated benchmarks by [@​mcollina](https://github.com/mcollina) in [https://github.com/nodejs/undici/pull/2250](https://github.com/nodejs/undici/pull/2250) - Fix fetch in node v20.6.0 by [@​mcollina](https://github.com/mcollina) in [https://github.com/nodejs/undici/pull/2251](https://github.com/nodejs/undici/pull/2251) - Maybe fix v20 by [@​mcollina](https://github.com/mcollina) in [https://github.com/nodejs/undici/pull/2252](https://github.com/nodejs/undici/pull/2252) - feat: Add H2 support by [@​metcoder95](https://github.com/metcoder95) in [https://github.com/nodejs/undici/pull/2061](https://github.com/nodejs/undici/pull/2061) - docs: fix tables in README by [@​regseb](https://github.com/regseb) in [https://github.com/nodejs/undici/pull/2254](https://github.com/nodejs/undici/pull/2254) - Fix http2 fetch test by [@​mcollina](https://github.com/mcollina) in [https://github.com/nodejs/undici/pull/2253](https://github.com/nodejs/undici/pull/2253) #### New Contributors - [@​NBNGaming](https://github.com/NBNGaming) made their first contribution in [https://github.com/nodejs/undici/pull/2162](https://github.com/nodejs/undici/pull/2162) - [@​capaj](https://github.com/capaj) made their first contribution in [https://github.com/nodejs/undici/pull/2220](https://github.com/nodejs/undici/pull/2220) - [@​regseb](https://github.com/regseb) made their first contribution in [https://github.com/nodejs/undici/pull/2254](https://github.com/nodejs/undici/pull/2254) **Full Changelog**: nodejs/undici@v5.23.0...v5.24.0 ### [`v5.23.0`](https://github.com/nodejs/undici/releases/tag/v5.23.0) [Compare Source](https://github.com/nodejs/undici/compare/v5.22.1...v5.23.0) #### What's Changed - bump engines to node >= 16 by [@​ronag](https://github.com/ronag) in [https://github.com/nodejs/undici/pull/2119](https://github.com/nodejs/undici/pull/2119) - Revert "bump engines to node >= 16 ([#​2119](https://github.com/nodejs/undici/issues/2119))" by [@​ronag](https://github.com/ronag) in [https://github.com/nodejs/undici/pull/2121](https://github.com/nodejs/undici/pull/2121) - fetch: set referrer properly by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2125](https://github.com/nodejs/undici/pull/2125) - fix: support truncated gzip by [@​jimmywarting](https://github.com/jimmywarting) in [https://github.com/nodejs/undici/pull/2126](https://github.com/nodejs/undici/pull/2126) - workflow: apply security best practices by [@​step-security-bot](https://github.com/step-security-bot) in [https://github.com/nodejs/undici/pull/2130](https://github.com/nodejs/undici/pull/2130) - build(deps): bump actions/upload-artifact from 3.1.0 to 3.1.2 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2135](https://github.com/nodejs/undici/pull/2135) - build(deps): bump actions/dependency-review-action from 2.5.1 to 3.0.4 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2133](https://github.com/nodejs/undici/pull/2133) - build(deps): bump node from 18-alpine to 20-alpine in /build by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2131](https://github.com/nodejs/undici/pull/2131) - build(deps): bump pkgjs/action from 0.1.6 to 0.1.7 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2136](https://github.com/nodejs/undici/pull/2136) - build(deps): bump actions/checkout from 3.1.0 to 3.5.2 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2132](https://github.com/nodejs/undici/pull/2132) - build(deps-dev): bump jsdom from 21.1.2 to 22.1.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2142](https://github.com/nodejs/undici/pull/2142) - build(deps): bump fastify/github-action-merge-dependabot from 3.7.0 to 3.8.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2148](https://github.com/nodejs/undici/pull/2148) - fix(pr): use correct pr template file by [@​AugustinMauroy](https://github.com/AugustinMauroy) in [https://github.com/nodejs/undici/pull/2141](https://github.com/nodejs/undici/pull/2141) - Additional WebSocket send tests to cover all payload size categories by [@​jawj](https://github.com/jawj) in [https://github.com/nodejs/undici/pull/2149](https://github.com/nodejs/undici/pull/2149) - fix: reverse decompression order of "Content-Encoding" encodings (fixes [#​2158](https://github.com/nodejs/undici/issues/2158)) by [@​rychkog](https://github.com/rychkog) in [https://github.com/nodejs/undici/pull/2159](https://github.com/nodejs/undici/pull/2159) - fix: keep running WPTs if a test times out by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2165](https://github.com/nodejs/undici/pull/2165) - feat: add build environment info by [@​mhdawson](https://github.com/mhdawson) in [https://github.com/nodejs/undici/pull/2168](https://github.com/nodejs/undici/pull/2168) - fix: forward error reason to fetch controller by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2172](https://github.com/nodejs/undici/pull/2172) - stricter types for bodymixin.json by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2181](https://github.com/nodejs/undici/pull/2181) - chore: Renable autoSelectFamily tests. by [@​ShogunPanda](https://github.com/ShogunPanda) in [https://github.com/nodejs/undici/pull/2180](https://github.com/nodejs/undici/pull/2180) - build(deps): bump actions/dependency-review-action from 3.0.4 to 3.0.6 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2147](https://github.com/nodejs/undici/pull/2147) - build(deps): bump github/codeql-action from 2.3.2 to 2.20.3 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2185](https://github.com/nodejs/undici/pull/2185) - fix: fetch resource timing performance entry names should be strings by [@​GaryWilber](https://github.com/GaryWilber) in [https://github.com/nodejs/undici/pull/2188](https://github.com/nodejs/undici/pull/2188) - build(deps): bump actions/checkout from 3.5.2 to 3.5.3 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2176](https://github.com/nodejs/undici/pull/2176) - build(deps): bump fastify/github-action-merge-dependabot from 3.8.0 to 3.9.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2177](https://github.com/nodejs/undici/pull/2177) - build(deps): bump ossf/scorecard-action from 2.1.3 to 2.2.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2178](https://github.com/nodejs/undici/pull/2178) - build(deps): bump step-security/harden-runner from 2.4.0 to 2.4.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2175](https://github.com/nodejs/undici/pull/2175) - test: fix `autoselectfamily` on platforms without IPv6 support by [@​LiviaMedeiros](https://github.com/LiviaMedeiros) in [https://github.com/nodejs/undici/pull/2197](https://github.com/nodejs/undici/pull/2197) - fix: make multipart/form-data boundary string more consistent by [@​LiviaMedeiros](https://github.com/LiviaMedeiros) in [https://github.com/nodejs/undici/pull/2196](https://github.com/nodejs/undici/pull/2196) - docs: add proxy agent options docs by [@​dancastillo](https://github.com/dancastillo) in [https://github.com/nodejs/undici/pull/2193](https://github.com/nodejs/undici/pull/2193) - build(deps): bump github/codeql-action from 2.20.3 to 2.21.2 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2205](https://github.com/nodejs/undici/pull/2205) - feat: make use of `addAbortListener` where applicable by [@​atlowChemi](https://github.com/atlowChemi) in [https://github.com/nodejs/undici/pull/2195](https://github.com/nodejs/undici/pull/2195) #### New Contributors - [@​step-security-bot](https://github.com/step-security-bot) made their first contribution in [https://github.com/nodejs/undici/pull/2130](https://github.com/nodejs/undici/pull/2130) - [@​AugustinMauroy](https://github.com/AugustinMauroy) made their first contribution in [https://github.com/nodejs/undici/pull/2141](https://github.com/nodejs/undici/pull/2141) - [@​rychkog](https://github.com/rychkog) made their first contribution in [https://github.com/nodejs/undici/pull/2159](https://github.com/nodejs/undici/pull/2159) - [@​mhdawson](https://github.com/mhdawson) made their first contribution in [https://github.com/nodejs/undici/pull/2168](https://github.com/nodejs/undici/pull/2168) - [@​GaryWilber](https://github.com/GaryWilber) made their first contribution in [https://github.com/nodejs/undici/pull/2188](https://github.com/nodejs/undici/pull/2188) - [@​atlowChemi](https://github.com/atlowChemi) made their first contribution in [https://github.com/nodejs/undici/pull/2195](https://github.com/nodejs/undici/pull/2195) **Full Changelog**: nodejs/undici@v5.22.1...v5.23.0 ### [`v5.22.1`](https://github.com/nodejs/undici/releases/tag/v5.22.1) [Compare Source](https://github.com/nodejs/undici/compare/v5.22.0...v5.22.1) #### What's Changed - Cache storage by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2076](https://github.com/nodejs/undici/pull/2076) - test: skip content-disposition test in node 18 by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2081](https://github.com/nodejs/undici/pull/2081) - Cache storage cleanup by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2082](https://github.com/nodejs/undici/pull/2082) - Cache storage fixes by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2083](https://github.com/nodejs/undici/pull/2083) - test: improve test coverage for ErrorEvent and MessageEvent by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2085](https://github.com/nodejs/undici/pull/2085) - test: remove --experimental-wasm-simd by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2087](https://github.com/nodejs/undici/pull/2087) - websocket: add websocketinit by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2088](https://github.com/nodejs/undici/pull/2088) - feat(websocket): allow setting custom headers by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2089](https://github.com/nodejs/undici/pull/2089) - test: fix tests failing only on node v20 by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2096](https://github.com/nodejs/undici/pull/2096) - fix: skip set content-length when FormData value is stream by [@​fengmk2](https://github.com/fengmk2) in [https://github.com/nodejs/undici/pull/2091](https://github.com/nodejs/undici/pull/2091) - doc: update outdated command in contributing.md by [@​jazelly](https://github.com/jazelly) in [https://github.com/nodejs/undici/pull/2099](https://github.com/nodejs/undici/pull/2099) - cache: fix most failing WPTs by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2100](https://github.com/nodejs/undici/pull/2100) - feat: allow build:wasm to auto detect platform by [@​jazelly](https://github.com/jazelly) in [https://github.com/nodejs/undici/pull/2102](https://github.com/nodejs/undici/pull/2102) - docs: updated Error documentation (fixes [#​2090](https://github.com/nodejs/undici/issues/2090)) by [@​titanism](https://github.com/titanism) in [https://github.com/nodejs/undici/pull/2092](https://github.com/nodejs/undici/pull/2092) - mimesniff: fix many broken tests by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2103](https://github.com/nodejs/undici/pull/2103) - test: fix failing tests by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2097](https://github.com/nodejs/undici/pull/2097) - build(deps): bump github/codeql-action from 2.2.9 to 2.3.2 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2105](https://github.com/nodejs/undici/pull/2105) - fix: more informative error message to tell that the server doesn't match http/1.1 protocol by [@​Songkeys](https://github.com/Songkeys) in [https://github.com/nodejs/undici/pull/2055](https://github.com/nodejs/undici/pull/2055) - Fix bug in 16-bit frame length when buffer is a subarray by [@​jawj](https://github.com/jawj) in [https://github.com/nodejs/undici/pull/2106](https://github.com/nodejs/undici/pull/2106) - update wpts by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2108](https://github.com/nodejs/undici/pull/2108) - fix: update error definitions by [@​dfilatov](https://github.com/dfilatov) in [https://github.com/nodejs/undici/pull/2112](https://github.com/nodejs/undici/pull/2112) - fix: make assertion a noop by [@​ronag](https://github.com/ronag) in [https://github.com/nodejs/undici/pull/2111](https://github.com/nodejs/undici/pull/2111) #### New Contributors - [@​jazelly](https://github.com/jazelly) made their first contribution in [https://github.com/nodejs/undici/pull/2099](https://github.com/nodejs/undici/pull/2099) - [@​titanism](https://github.com/titanism) made their first contribution in [https://github.com/nodejs/undici/pull/2092](https://github.com/nodejs/undici/pull/2092) - [@​Songkeys](https://github.com/Songkeys) made their first contribution in [https://github.com/nodejs/undici/pull/2055](https://github.com/nodejs/undici/pull/2055) - [@​jawj](https://github.com/jawj) made their first contribution in [https://github.com/nodejs/undici/pull/2106](https://github.com/nodejs/undici/pull/2106) - [@​dfilatov](https://github.com/dfilatov) made their first contribution in [https://github.com/nodejs/undici/pull/2112](https://github.com/nodejs/undici/pull/2112) **Full Changelog**: nodejs/undici@v5.22.0...v5.22.1 ### [`v5.22.0`](https://github.com/nodejs/undici/releases/tag/v5.22.0) [Compare Source](https://github.com/nodejs/undici/compare/v5.21.2...v5.22.0) #### What's Changed - build(deps-dev): bump tsd from 0.27.0 to 0.28.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2042](https://github.com/nodejs/undici/pull/2042) - build(deps): bump ossf/scorecard-action from 2.1.2 to 2.1.3 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2040](https://github.com/nodejs/undici/pull/2040) - fix: handle opaque origin in sameOrigin by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2053](https://github.com/nodejs/undici/pull/2053) - test: add typescript import test back by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2054](https://github.com/nodejs/undici/pull/2054) - fix: use getMaxListeners when available by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2063](https://github.com/nodejs/undici/pull/2063) - feat: allow overriding hwm by [@​ronag](https://github.com/ronag) in [https://github.com/nodejs/undici/pull/2057](https://github.com/nodejs/undici/pull/2057) - fix: there is no sync connector by [@​ronag](https://github.com/ronag) in [https://github.com/nodejs/undici/pull/2059](https://github.com/nodejs/undici/pull/2059) - fix: rename .wasm to -wasm to appease jest by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2064](https://github.com/nodejs/undici/pull/2064) - fix: set content-length when using FormData body w/ request by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2066](https://github.com/nodejs/undici/pull/2066) - refactor: unify error body handling by [@​ronag](https://github.com/ronag) in [https://github.com/nodejs/undici/pull/2060](https://github.com/nodejs/undici/pull/2060) - fix: close and destroy overlap by [@​ronag](https://github.com/ronag) in [https://github.com/nodejs/undici/pull/2068](https://github.com/nodejs/undici/pull/2068) - remove node 12 from test matrix by [@​ronag](https://github.com/ronag) in [https://github.com/nodejs/undici/pull/2069](https://github.com/nodejs/undici/pull/2069) - fix: don't leak socket if client is destroyed while connecting by [@​ronag](https://github.com/ronag) in [https://github.com/nodejs/undici/pull/2058](https://github.com/nodejs/undici/pull/2058) - fix: flaky leak test by [@​ronag](https://github.com/ronag) in [https://github.com/nodejs/undici/pull/2070](https://github.com/nodejs/undici/pull/2070) - test: update wpts by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2073](https://github.com/nodejs/undici/pull/2073) - perf: latin1 by [@​ronag](https://github.com/ronag) in [https://github.com/nodejs/undici/pull/2075](https://github.com/nodejs/undici/pull/2075) - fix: mock fetch headers shouldn't be an array by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2080](https://github.com/nodejs/undici/pull/2080) **Full Changelog**: nodejs/undici@v5.21.2...v5.22.0 ### [`v5.21.2`](https://github.com/nodejs/undici/releases/tag/v5.21.2) [Compare Source](https://github.com/nodejs/undici/compare/v5.21.1...v5.21.2) #### What's Changed - Content disposition parsing by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2051](https://github.com/nodejs/undici/pull/2051) - fix: clear set-cookie headers by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2052](https://github.com/nodejs/undici/pull/2052) **Full Changelog**: nodejs/undici@v5.21.1...v5.21.2 ### [`v5.21.1`](https://github.com/nodejs/undici/releases/tag/v5.21.1) [Compare Source](https://github.com/nodejs/undici/compare/v5.21.0...v5.21.1) #### What's Changed - Fix typo in kPipelining symbol by [@​andrewfecenko](https://github.com/andrewfecenko) in [https://github.com/nodejs/undici/pull/2005](https://github.com/nodejs/undici/pull/2005) - fix(fetch): remove `undefined` error cause by [@​aduh95](https://github.com/aduh95) in [https://github.com/nodejs/undici/pull/2006](https://github.com/nodejs/undici/pull/2006) - chore(deps-dev): bump tsd from 0.25.0 to 0.27.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2007](https://github.com/nodejs/undici/pull/2007) - build(deps-dev): bump wait-on from 6.0.1 to 7.0.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/1820](https://github.com/nodejs/undici/pull/1820) - fix(wpt): set global META_TITLE for the runner by [@​panva](https://github.com/panva) in [https://github.com/nodejs/undici/pull/2008](https://github.com/nodejs/undici/pull/2008) - fix: issue 2009 by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2013](https://github.com/nodejs/undici/pull/2013) - build(deps-dev): bump typescript from 4.9.5 to 5.0.2 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2018](https://github.com/nodejs/undici/pull/2018) - added descriptive error messages for URL parser by [@​RishabhKodes](https://github.com/RishabhKodes) in [https://github.com/nodejs/undici/pull/2016](https://github.com/nodejs/undici/pull/2016) - fix(fetch): remove content-length header on redirect by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2022](https://github.com/nodejs/undici/pull/2022) - fix(fetch): remove assertion on request.body.source on redirect ([#​2027](https://github.com/nodejs/undici/issues/2027)) by [@​macno](https://github.com/macno) in [https://github.com/nodejs/undici/pull/2028](https://github.com/nodejs/undici/pull/2028) - fix: skip failing test in node >= v19.8 by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2034](https://github.com/nodejs/undici/pull/2034) - fetch: treat content-encoding as case-insensitive & remove x-deflate by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2037](https://github.com/nodejs/undici/pull/2037) - perf(fetch): use string comparisons for url schemes by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2038](https://github.com/nodejs/undici/pull/2038) - util: replace util.toUSVString with String.prototype.toWellFormed by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2036](https://github.com/nodejs/undici/pull/2036) - build(deps): bump github/codeql-action from 2.2.4 to 2.2.9 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2039](https://github.com/nodejs/undici/pull/2039) - build(deps-dev): bump concurrently from 7.6.0 to 8.0.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/nodejs/undici/pull/2041](https://github.com/nodejs/undici/pull/2041) - Small performance improvements by [@​anonrig](https://github.com/anonrig) in [https://github.com/nodejs/undici/pull/2044](https://github.com/nodejs/undici/pull/2044) - fix(types): Add missing Blob import by [@​dpogue](https://github.com/dpogue) in [https://github.com/nodejs/undici/pull/2047](https://github.com/nodejs/undici/pull/2047) - fix: set window option properly by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2048](https://github.com/nodejs/undici/pull/2048) - fetch: fix leak by [@​ronag](https://github.com/ronag) in [https://github.com/nodejs/undici/pull/2049](https://github.com/nodejs/undici/pull/2049) #### New Contributors - [@​aduh95](https://github.com/aduh95) made their first contribution in [https://github.com/nodejs/undici/pull/2006](https://github.com/nodejs/undici/pull/2006) - [@​RishabhKodes](https://github.com/RishabhKodes) made their first contribution in [https://github.com/nodejs/undici/pull/2016](https://github.com/nodejs/undici/pull/2016) - [@​macno](https://github.com/macno) made their first contribution in [https://github.com/nodejs/undici/pull/2028](https://github.com/nodejs/undici/pull/2028) - [@​dpogue](https://github.com/dpogue) made their first contribution in [https://github.com/nodejs/undici/pull/2047](https://github.com/nodejs/undici/pull/2047) **Full Changelog**: nodejs/undici@v5.21.0...v5.21.1 ### [`v5.21.0`](https://github.com/nodejs/undici/releases/tag/v5.21.0) [Compare Source](https://github.com/nodejs/undici/compare/v5.20.0...v5.21.0) ##### What's Changed - workflow: add scorecard.yml by [@​RafaelGSS](https://github.com/RafaelGSS) in [https://github.com/nodejs/undici/pull/1942](https://github.com/nodejs/undici/pull/1942) - ci: timeout CI jobs after 15 minutes by [@​dominykas](https://github.com/dominykas) in [https://github.com/nodejs/undici/pull/1946](https://github.com/nodejs/undici/pull/1946) - test(wpt): respect variants by [@​panva](https://github.com/panva) in [https://github.com/nodejs/undici/pull/1951](https://github.com/nodejs/undici/pull/1951) - fix: improve isFormDataLike compat by [@​ronag](https://github.com/ronag) in [https://github.com/nodejs/undici/pull/1953](https://github.com/nodejs/undici/pull/1953) - fix: flaky fetch tests by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/1956](https://github.com/nodejs/undici/pull/1956) - test(wpt): include all testing files by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/1954](https://github.com/nodejs/undici/pull/1954) - fix: remove unneeded fetch tests by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/1960](https://github.com/nodejs/undici/pull/1960) - fix: use normal timers for delays < 1s by [@​ronag](https://github.com/ronag) in [https://github.com/nodejs/undici/pull/1961](https://github.com/nodejs/undici/pull/1961) - perf: optimize happy path by [@​anonrig](https://github.com/anonrig) in [https://github.com/nodejs/undici/pull/1955](https://github.com/nodejs/undici/pull/1955) - fix: 🐛 add URL upstream variations in BalancedPool types by [@​jimmy-guzman](https://github.com/jimmy-guzman) in [https://github.com/nodejs/undici/pull/1966](https://github.com/nodejs/undici/pull/1966) - test(wpt): handle uncaught exceptions by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/1965](https://github.com/nodejs/undici/pull/1965) - Fix failing wpts by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/1967](https://github.com/nodejs/undici/pull/1967) - test(wpt): add results to an existing WPT Report by [@​panva](https://github.com/panva) in [https://github.com/nodejs/undici/pull/1944](https://github.com/nodejs/undici/pull/1944) - fix: strengthen isStream condition checking by [@​debadree25](https://github.com/debadree25) in [https://github.com/nodejs/undici/pull/1969](https://github.com/nodejs/undici/pull/1969) - fix: implement basic policy container by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/1970](https://github.com/nodejs/undici/pull/1970) - TypeScript type fixes, for [#​1949](https://github.com/nodejs/undici/issues/1949) by [@​joshxyzhimself](https://github.com/joshxyzhimself) in [https://github.com/nodejs/undici/pull/1968](https://github.com/nodejs/undici/pull/1968) - websocket: separate connection logic from websocket by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/1973](https://github.com/nodejs/undici/pull/1973) - README: h3 not showing ### as a header by [@​hilleer](https://github.com/hilleer) in [https://github.com/nodejs/undici/pull/1975](https://github.com/nodejs/undici/pull/1975) - wptrunner: expose gc by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/1974](https://github.com/nodejs/undici/pull/1974) - perf: cork socket before writing by [@​ronag](https://github.com/ronag) in [https://github.com/nodejs/undici/pull/1982](https://github.com/nodejs/undici/pull/1982) - fix: fast timers and event loop lag by [@​ronag](https://github.com/ronag) in [https://github.com/nodejs/undici/pull/1977](https://github.com/nodejs/undici/pull/1977) - fix: correctly calculate resource timing duration by [@​amilajack](https://github.com/amilajack) in [https://github.com/nodejs/undici/pull/1988](https://github.com/nodejs/undici/pull/1988) - wpt: update tests by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/1984](https://github.com/nodejs/undici/pull/1984) - fix: undici stream throwOnError by [@​dancastillo](https://github.com/dancastillo) in [https://github.com/nodejs/undici/pull/1995](https://github.com/nodejs/undici/pull/1995) - fix: remove unnecessary WeakRef by [@​ronag](https://github.com/ronag) in [https://github.com/nodejs/undici/pull/2000](https://github.com/nodejs/undici/pull/2000) - Fix: websocket.d.ts - error TS2304: Cannot find name 'MessagePort' by [@​ZaBlazzingZephyrus](https://github.com/ZaBlazzingZephyrus) in [https://github.com/nodejs/undici/pull/1997](https://github.com/nodejs/undici/pull/1997) - feat: add abort signal to body.dump() by [@​debadree25](https://github.com/debadree25) in [https://github.com/nodejs/undici/pull/1993](https://github.com/nodejs/undici/pull/1993) - fix(fetch): third party abortcontrollers throwing errors by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/2002](https://github.com/nodejs/undici/pull/2002) - Improve ProxyAgent example with autentication by [@​egmen](https://github.com/egmen) in [https://github.com/nodejs/undici/pull/2004](https://github.com/nodejs/undici/pull/2004) - Add clientFactory option to ProxyAgent by [@​andrewfecenko](https://github.com/andrewfecenko) in [https://github.com/nodejs/undici/pull/2003](https://github.com/nodejs/undici/pull/2003) ##### New Contributors - [@​jimmy-guzman](https://github.com/jimmy-guzman) made their first contribution in [https://github.com/nodejs/undici/pull/1966](https://github.com/nodejs/undici/pull/1966) - [@​hilleer](https://github.com/hilleer) made their first contribution in [https://github.com/nodejs/undici/pull/1975](https://github.com/nodejs/undici/pull/1975) - [@​amilajack](https://github.com/amilajack) made their first contribution in [https://github.com/nodejs/undici/pull/1988](https://github.com/nodejs/undici/pull/1988) - [@​ZaBlazzingZephyrus](https://github.com/ZaBlazzingZephyrus) made their first contribution in [https://github.com/nodejs/undici/pull/1997](https://github.com/nodejs/undici/pull/1997) - [@​egmen](https://github.com/egmen) made their first contribution in [https://github.com/nodejs/undici/pull/2004](https://github.com/nodejs/undici/pull/2004) - [@​andrewfecenko](https://github.com/andrewfecenko) made their first contribution in [https://github.com/nodejs/undici/pull/2003](https://github.com/nodejs/undici/pull/2003) **Full Changelog**: nodejs/undici@v5.20.0...v5.21.0 ### [`v5.20.0`](https://github.com/nodejs/undici/releases/tag/v5.20.0) [Compare Source](https://github.com/nodejs/undici/compare/v5.19.1...v5.20.0) #### What's Changed - perf: improve cookie parsing performance by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/1931](https://github.com/nodejs/undici/pull/1931) - fix: disable websocket wpts in ci :( by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/1932](https://github.com/nodejs/undici/pull/1932) - fix: Allow “undefined“ as value in headers by [@​pan93412](https://github.com/pan93412) in [https://github.com/nodejs/undici/pull/1929](https://github.com/nodejs/undici/pull/1929) - feat: Support autoSelectFamily when connecting. by [@​ShogunPanda](https://github.com/ShogunPanda) in [https://github.com/nodejs/undici/pull/1914](https://github.com/nodejs/undici/pull/1914) - fix: copy cookies when cloning haders by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/1936](https://github.com/nodejs/undici/pull/1936) - test: more logs in wpt runner by [@​KhafraDev](https://github.com/KhafraDev) in [https://github.com/nodejs/undici/pull/1933](https://github.com/nodejs/undici/pull/1933) - feat: change headersTimeout and bodyTimeout to 300s by [@​kyrylkov](https://github.com/kyrylkov) in [https://github.com/nodejs/undici/pull/1937](https://github.com/nodejs/undici/pull/1937) **Full Changelog**: nodejs/undici@v5.19.1...v5.20.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Canary-nextjs).
1 task
|
As a further datapoint about this issue, we have an application that experienced a memory leak when moving from node 16, to node 18.19 + undici 5.22.0. We tried upgrading to undici 6.6.2 and while there seemed to be some improvement, we didn't get true relief until we followed: and pinned undici to 5.20.0. I note that this PR was merged immediately after 5.20.0 |
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
](https://renovatebot.com){kind=link}
It's sufficient that the finalizer removes the closure. Fixes: nodejs#1926
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's sufficient that the finalizer removes the closure.
Fixes: #1926