feat: add abort signal to body.dump()

lib/api/readable.js

@@ -147,38 +147,25 @@ module.exports = class BodyReadable extends Readable {
   async dump (opts) {
     let limit = opts && Number.isFinite(opts.limit) ? opts.limit : 262144
     const signal = opts && opts.signal
-    function throwIfAborted () {
-      if (!signal) { return }
-      if (signal.throwIfAborted) {
-        signal.throwIfAborted()
-      } else {
-        if (signal.aborted) {
-          // DOMException not available < v17.0.0
-          const err = new Error('The operation was aborted')
-          err.name = 'AbortError'
-          throw err
-        }
-      }
-    }
     if (signal) {
       if (typeof signal !== 'object' || !('aborted' in signal)) {
         throw new InvalidArgumentError('signal must be an AbortSignal')
       }
-      throwIfAborted()
+      util.throwIfAborted(signal)
       signal.addEventListener('abort', () => {
         this.destroy()
-      })
+      }, { once: true })
     }
     try {
       for await (const chunk of this) {
-        throwIfAborted()
+        util.throwIfAborted(signal)
         limit -= Buffer.byteLength(chunk)
         if (limit < 0) {
           return
         }
       }
     } catch {
-      throwIfAborted()
+      util.throwIfAborted(signal)
     }
   }
 }

lib/core/util.js

@@ -389,6 +389,20 @@ function isFormDataLike (object) {
   )
 }
 
+function throwIfAborted (signal) {
+  if (!signal) { return }
+  if (signal.throwIfAborted) {
+    signal.throwIfAborted()
+  } else {
+    if (signal.aborted) {
+      // DOMException not available < v17.0.0
+      const err = new Error('The operation was aborted')
+      err.name = 'AbortError'
+      throw err
+    }
+  }
+}
+
 const kEnumerableProperty = Object.create(null)
 kEnumerableProperty.enumerable = true
 
@@ -420,6 +434,7 @@ module.exports = {
   getSocketInfo,
   isFormDataLike,
   buildURL,
+  throwIfAborted,
   nodeMajor,
   nodeMinor,
   nodeHasAutoSelectFamily: nodeMajor > 18 || (nodeMajor === 18 && nodeMinor >= 13)