Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fetch): raise AbortSignal max event listeners #1910

Merged
merged 1 commit into from
Feb 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/fetch/request.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ const { getGlobalOrigin } = require('./global')
const { URLSerializer } = require('./dataURL')
const { kHeadersList } = require('../core/symbols')
const assert = require('assert')
const { setMaxListeners, getEventListeners, defaultMaxListeners } = require('events')

let TransformStream = globalThis.TransformStream

Expand Down Expand Up @@ -352,6 +353,11 @@ class Request {
const abort = function () {
acRef.deref()?.abort(this.reason)
}

if (getEventListeners(signal, 'abort').length >= defaultMaxListeners) {
setMaxListeners(100, signal)
}

signal.addEventListener('abort', abort, { once: true })
requestFinalizer.register(this, { signal, abort })
}
Expand Down
28 changes: 28 additions & 0 deletions test/fetch/issue-node-46525.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
'use strict'

const { once } = require('events')
const { createServer } = require('http')
const { test } = require('tap')
const { fetch } = require('../..')

// https://github.com/nodejs/node/issues/46525
test('No warning when reusing AbortController', async (t) => {
function onWarning (error) {
t.error(error, 'Got warning')
}

const server = createServer((req, res) => res.end()).listen(0)

await once(server, 'listening')

process.on('warning', onWarning)
t.teardown(() => {
process.off('warning', onWarning)
return server.close()
})

const controller = new AbortController()
for (let i = 0; i < 15; i++) {
await fetch(`http://localhost:${server.address().port}`, { signal: controller.signal })
}
})