Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wpt: add test #1836

Merged
merged 2 commits into from
Dec 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/fetch/body.js
Original file line number Diff line number Diff line change
Expand Up @@ -357,8 +357,7 @@ function bodyMixinMethods (instance) {
defParamCharset: 'utf8'
})
} catch (err) {
// Error due to headers:
throw Object.assign(new TypeError(), { cause: err })
throw new DOMException(`${err}`, 'AbortError')
}

busboy.on('field', (name, value) => {
Expand Down
50 changes: 50 additions & 0 deletions test/wpt/tests/fetch/api/body/cloned-any.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
// Changing the body after it have been passed to Response/Request
// should not change the outcome of the consumed body

const url = 'http://a';
const method = 'post';

promise_test(async t => {
const body = new FormData();
body.set('a', '1');
const res = new Response(body);
const req = new Request(url, { method, body });
body.set('a', '2');
assert_true((await res.formData()).get('a') === '1');
assert_true((await req.formData()).get('a') === '1');
}, 'FormData is cloned');

promise_test(async t => {
const body = new URLSearchParams({a: '1'});
const res = new Response(body);
const req = new Request(url, { method, body });
body.set('a', '2');
assert_true((await res.formData()).get('a') === '1');
assert_true((await req.formData()).get('a') === '1');
}, 'URLSearchParams is cloned');

promise_test(async t => {
const body = new Uint8Array([97]); // a
const res = new Response(body);
const req = new Request(url, { method, body });
body[0] = 98; // b
assert_true(await res.text() === 'a');
assert_true(await req.text() === 'a');
}, 'TypedArray is cloned');

promise_test(async t => {
const body = new Uint8Array([97]); // a
const res = new Response(body.buffer);
const req = new Request(url, { method, body: body.buffer });
body[0] = 98; // b
assert_true(await res.text() === 'a');
assert_true(await req.text() === 'a');
}, 'ArrayBuffer is cloned');

promise_test(async t => {
const body = new Blob(['a']);
const res = new Response(body);
const req = new Request(url, { method, body });
assert_true(await res.blob() !== body);
assert_true(await req.blob() !== body);
}, 'Blob is cloned');