BalancedPool types don't account for all upstreams variations

[jimmy-guzman]

Bug Description

Unless I'm missing something but shouldn't the types for BalancedPool, allow for URL[]. Based on the types it seems like it doesn't but then the implementation seems like it should/can.

Also, should addUpstream allow URL?

Ignoring TypeScript errors, everything seems to work as expected

Reproducible By

const pool = new BalancedPool([new URL("https://github.com/")]);
// Type 'URL' is not assignable to type 'string'.ts(2322)

pool.addUpstream(new URL("https://github.com/"));
// Argument of type 'URL' is not assignable to parameter of type 'string'.ts(2345)

Expected Behavior

The following should not cause typescript errors

const pool = new BalancedPool([new URL("https://github.com/")])

pool.addUpstream(new URL("https://github.com/"));

Logs & Screenshots

Environment

TypeScript: 4.9.5
Node: v18.12.1

[mcollina]

Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests, we use tsd for typescript.

[jimmy-guzman]

@mcollina Thanks for the quick reply. I'll make a PR for this.