fix: improve isFormDataLike compat (#1953)

Fixes: #1952
nodejs · Feb 21, 2023 · ab494d2 · ab494d2
1 parent 5851019
commit ab494d2
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 14 deletions.
diff --git a/lib/core/util.js b/lib/core/util.js
@@ -375,20 +375,17 @@ function ReadableStreamFrom (iterable) {
 
 // The chunk should be a FormData instance and contains
 // all the required methods.
-function isFormDataLike (chunk) {
-  return (chunk &&
-    chunk.constructor && chunk.constructor.name === 'FormData' &&
-    typeof chunk === 'object' &&
-      (typeof chunk.append === 'function' &&
-        typeof chunk.delete === 'function' &&
-        typeof chunk.get === 'function' &&
-        typeof chunk.getAll === 'function' &&
-        typeof chunk.has === 'function' &&
-        typeof chunk.set === 'function' &&
-        typeof chunk.entries === 'function' &&
-        typeof chunk.keys === 'function' &&
-        typeof chunk.values === 'function' &&
-        typeof chunk.forEach === 'function')
+function isFormDataLike (object) {
+  return (
+    object &&
+    typeof object === 'object' &&
+    typeof object.append === 'function' &&
+    typeof object.delete === 'function' &&
+    typeof object.get === 'function' &&
+    typeof object.getAll === 'function' &&
+    typeof object.has === 'function' &&
+    typeof object.set === 'function' &&
+    object[Symbol.toStringTag] === 'FormData'
   )
 }
 

diff --git a/test/fetch/formdata.js b/test/fetch/formdata.js
@@ -349,6 +349,10 @@ test('FormData should be compatible with third-party libraries', (t) => {
       this.data = []
     }
 
+    get [Symbol.toStringTag] () {
+      return 'FormData'
+    }
+
     append () {}
     delete () {}
     get () {}